Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#7134: Use a separate docstring class for BasePandasDataset. #7353

Merged
merged 1 commit into from
Jul 31, 2024
Merged

FIX-#7134: Use a separate docstring class for BasePandasDataset. #7353

merged 1 commit into from
Jul 31, 2024

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: BasePandasDataset tries to inherit custom docstrings from DataFrame instead of from a separate base class #7134
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@sfc-gh-mvashishtha
FIX-modin-project#7134: Use a separate docstring class for BasePandas…
2006084 
…Dataset.

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 30, 2024
View reviewed changes
modin/tests/config/docs_module/classes.py Dismissed Show dismissed Hide dismissed
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review July 31, 2024 02:01
@YarShev YarShev merged commit 24018db into modin-project:main Jul 31, 2024
38 checks passed
arunjose696 pushed a commit to arunjose696/modin that referenced this pull request Aug 1, 2024
@sfc-gh-mvashishtha @arunjose696
FIX-modin-project#7134: Use a separate docstring class for BasePandas…
3014693 
…Dataset. (modin-project#7353)

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: BasePandasDataset tries to inherit custom docstrings from DataFrame instead of from a separate base class
2 participants
@sfc-gh-mvashishtha @YarShev