Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#7308: Interoperability between query compilers #7376
FEAT-#7308: Interoperability between query compilers #7376
Changes from 29 commits
ba48d29
40e1cd4
a574172
6f9795b
07d8d3a
ac75854
52b3136
4aed823
7149ba3
b0e0a82
507d58a
88a6207
b01f7b9
1a61931
a105677
8e29fbe
1620f82
4392165
7a1a30f
4e24de2
2308295
d240ac8
a4c1697
89dabf9
b212c3b
90ba1a4
e9060a7
60f9512
80ce01c
6a068dc
cac89d2
8e8ec46
c1b0942
f488872
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 134 in modin/core/storage_formats/pandas/query_compiler_validator.py
Codecov / codecov/patch
modin/core/storage_formats/pandas/query_compiler_validator.py#L134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new_query_compiler can also be an instance of a different query compiler(Nativequerycompiler or PandasQueryCompiler),
Eg during operations like insert in the _create_or_update_from_compiler the constructor gets called directly eg ,
Thus it would be normal for the cases where constructor may return a new query compiler for a case where user changes the query compiler mode between creating data_frame and insert operation