Skip to content

Commit

Permalink
Remove virtual functions
Browse files Browse the repository at this point in the history
  • Loading branch information
rasmuskleist committed Aug 7, 2023
1 parent 7b77f09 commit c03bd15
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions src/modm/driver/radio/sx128x_transport.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ namespace modm
class Sx128xTransport
{
public:
struct
Command : sx128x
struct Command : sx128x
{
Command(Opcode opcode) : opcode(opcode) {}
Command(Opcode opcode, std::span<const uint8_t> vargs) : opcode(opcode), vargs(vargs) {}
Expand Down Expand Up @@ -73,16 +72,6 @@ class Sx128xTransport
Opcode opcode;
std::span<const uint8_t> vargs;
};

protected:
virtual modm::ResumableResult<bool>
writeCommandSingleData(Command command, uint8_t *data = nullptr) = 0;

virtual modm::ResumableResult<bool>
writeCommand(Command command, std::span<const uint8_t> data) = 0;

virtual modm::ResumableResult<bool>
readCommand(Command command, std::span<uint8_t> data) = 0;
};

/**
Expand Down

0 comments on commit c03bd15

Please sign in to comment.