RUST-911: Add srvServiceName URI option #1235
Open
+260
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
looking good so far - we'll also need to implement the prose test described here
src/srv.rs
Outdated
| @@ -90,14 +94,21 @@ pub(crate) enum DomainMismatch { | |||
| #[cfg(feature = "dns-resolver")] | |||
| pub(crate) struct SrvResolver { | |||
| resolver: crate::runtime::AsyncResolver, | |||
| client_options: Option<ClientOptions>, | |||
There was a problem hiding this comment.
suggest only storing the service name rather than the entire options struct - it looks like that's the only field being accessed from this
src/srv.rs
Outdated
| .unwrap_or(default_service_name), | ||
| }; | ||
| let lookup_hostname = format!("_{}._tcp.{}", service_name, original_hostname); | ||
| .unwrap_or("mongodb".to_string()), |
There was a problem hiding this comment.
tiny style nit: we can do the following to avoid allocating an extra string here
self.srv_service_name
.as_deref() // converts into an Option<&str> to get a reference to the inner string
.unwrap_or("mongodb")
|
disregard my comment about assertions, I misread which method was being called! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-911