Ensure that the assemblies are in fact signed #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
commented
May 1, 2020
| @@ -28,26 +28,26 @@ HarfBuzz soname 0.20601.0 | |||
|
|
|||
| # SkiaSharp.dll | |||
| SkiaSharp assembly 1.68.0.0 | |||
| SkiaSharp file 1.68.2.0 | |||
| SkiaSharp file 1.68.2.1 | |||
There was a problem hiding this comment.
Bump the versions... Pity to do it so soon.
| @@ -119,7 +119,8 @@ Task ("libs") | |||
| platform = ".Linux"; | |||
| } | |||
| } | |||
| RunMSBuild ($"./source/SkiaSharpSource{platform}.sln"); | |||
| RunMSBuild ($"./source/SkiaSharpSource{platform}.sln", | |||
| bl: $"./output/binlogs/libs{platform}.binlog"); | |||
There was a problem hiding this comment.
Get those binlogs.
Comment on lines
+9
to
+11
| <_SnExePath Condition=" '$(OS)' == 'Windows_NT' and '$(_SnExePath)' == '' and Exists('$(SDK40ToolsPath)sn.exe') ">$(SDK40ToolsPath)sn.exe</_SnExePath> | ||
| <_SnExePath Condition=" '$(OS)' == 'Windows_NT' and '$(_SnExePath)' == '' and Exists('$(MSBuildProgramFiles32)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\sn.exe') ">$(MSBuildProgramFiles32)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8 Tools\sn.exe</_SnExePath> | ||
| <_SnExePath Condition=" '$(_SnExePath)' == '' ">sn</_SnExePath> |
There was a problem hiding this comment.
Find the location of sn.exe
Comment on lines
+108
to
110
| <Target Name="_SignAssemblyVerify" AfterTargets="Build" Condition=" '$(SignAssembly)' == 'true' and '$(Configuration)' == 'Release' and '$(TargetPath)' != '' "> | ||
| <Exec Command=""$(_SnExePath)" -vf "$(TargetPath)"" /> | ||
| </Target> |
There was a problem hiding this comment.
VERIFY!
this does slow down the build loop by a few ms, but better safe than sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Ensure that the assemblies are in fact signed.
Since the addition of the
Xamarin.Build.TypeRedirectorNuGet package to fix up the VS2017 and VS2019 issues, the assembly is modified AFTER the signing, so that breaks it. This PR now specifies that the signing task depends on the redirection task.Type redirector issues:
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
PR Checklist