C# signatures for new operators #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement correct C# method signature output for the newer operators that currently aren't implemented: unsigned right shift and all of the checked operators.
|
@nickwalkmsft Thanks Nick. I granted you write permission to this repo, could you accept the invitation and directly push to a branch and then create a PR? Because the forked PR won't trigger the CI pipeline due to the security reason. And also the target branch should be |
|
Obsoleted by #713. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work items:
Implement correct C# method signature output for the newer operators that currently aren't implemented: unsigned right shift and all of the checked operators.
Added unit tests and tested locally against the types mentioned in the work items (BigInteger and Int128).
As with #710, I was unable to get C++ tests running, but nothing in that codepath should be affected.