Ignore exceptions trying to read IPTC-IIM data #344
Conversation
|
I've added a unit test after noticing this requirement in the README. |
StephenMcConnel
force-pushed
the
BL-11933-HandleUnknownIPTC
branch
from
a537587
to
d07dae8
Compare
|
@StephenMcConnel Sorry, for the delay. There are some complications I'm trying to sort out, but will try to be more on top of things in the meantime. |
| using System.Threading.Tasks; | ||
| using TaglibSharp.Tests.Images.Validators; | ||
| using TagLib.IFD; | ||
| using TagLib.Xmp; |
There was a problem hiding this comment.
Can you sort these with System at the top. Also, there are a couple duplicates in this list.
There was a problem hiding this comment.
If you can fix this, I'm good with the changes and will merge them.
There was a problem hiding this comment.
Actually, none of the System using statements were needed according to VS 2022, so I removed them along with the other redundant or otherwise unnecessary using statements.
StephenMcConnel
force-pushed
the
BL-11933-HandleUnknownIPTC
branch
from
d07dae8
to
19a6f5f
Compare
Having TagLibSharp just throw an exception when it can't read an IPTC-IIM segment is causing problems for some of our users.
This is the least important of the metadata segments, generally speaking, and the TagLibSharp code only pulls a handful of values
from it in any case. Our bug report at https://issues.bloomlibrary.org/youtrack/issue/BL-11933 has a jpeg image that shows
the problem. I can get around not being able to use the image at all by catching the exception in one of our libraries that
uses TagLibSharp, but it prevents other metadata from the file from being available, which causes some problems with suboptimal handling of the image file.