feat(deploy-ocpp-gateway): allow overriding infra-portal host and path prefix - #329
Merged
Merged
Conversation
…h prefix Adds optional `infra-portal-hostname` and `infra-portal-path-prefix` inputs. Both default to empty, which keeps the existing stage-derived behaviour byte-for-byte for every current caller. Needed so a production-stage release can target the v2 releaser on the internal portal, which is the only one that speaks HTTPRoute. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tobias0106
requested review from
chandrashekar-dhar
and removed request for
a team
August 20, 2026 14:28
Andree98
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two new optional inputs on the
deploy-ocpp-gatewaycomposite action, both defaulting to'':infra-portal-hostnameinfra-portal.internal.monta.appfor dev/staging,infra-portal.monta.appotherwiseinfra-portal-path-prefix/api/publicfor dev/staging, empty otherwiseEmpty = today's stage-derived logic, unchanged.
Why
Today host and path prefix are both derived from
stage, andstagecannot be changed — it also builds the namespace segment of the URL (${service-identifier}-${stage}must equal the k8s namespace) and feeds the manifest paths. So aproduction-stage release is hard-wired to:which is the legacy releaser. That one only speaks ALB Ingress —
getTrafficWeightsFromIngressdoes a plainIngresses(ns).Get()with noIsNotFoundfallback (api/legacy/internal/ocpp-gateway-rollout/Helper.go:481-489). The gateway onmain-productionrunsingress.enabled: falsebehind Envoy Gateway API, so the release aborts.The v2 releaser handles HTTPRoute weights, but it lives only on the internal portal and registers at
/api/public/...(api/core/internal/ocppgatewayreleaser/routes.go:25). Reaching it from a production stage needs both a different host and a different prefix — hence two inputs rather than one.Compatibility
gh api "search/code?q=org:monta-app+deploy-ocpp-gateway"returns three hits:service-ocpp'sdeploy-gateway-staging.ymlanddeploy-gateway-production.yml, plus this action's own README. Neither caller passes the new inputs, so both keep their exact current URLs.Consumer PR: monta-app/service-ocpp#3077
Follow-ups, deliberately not in this PR
infra-portal.staging.monta.appand doesn't documentinfra-portal-context.infra-portal-tokenis interpolated straight into thecurlargv. It is masked in logs but lands in the process argument list. Moving it (andgithub.sha) into anenv:block would be a cheap hardening win.