Skip to content

fix: Add optional skip-code-coverage-on-pr flag on pull-request-kotlin - #331

Merged
morten-andersen merged 1 commit into
mainfrom
fix/NOJIRA/add-flag-to-skip-code-coverage-on-prs
Aug 24, 2026
Merged

fix: Add optional skip-code-coverage-on-pr flag on pull-request-kotlin#331
morten-andersen merged 1 commit into
mainfrom
fix/NOJIRA/add-flag-to-skip-code-coverage-on-prs

Conversation

@morten-andersen

Copy link
Copy Markdown
Contributor

On public repositories like the ocpp-emulator we accept PRs from forked repositories.

For these the step to upload the code coverage on the PR will fail, so this makes it optional (defaults to on)

For pull_request events on a fork PR, GitHub Actions always issues a read-only GITHUB_TOKEN, regardless of what permissions: the workflow declares — this is a hard security restriction to prevent a malicious fork PR from using elevated permissions

…tlin`

On public repositories like the `ocpp-emulator` we accept PRs from forked repositories.

For these the step to upload the code coverage on the PR will fail, so this makes it optional (defaults to on)

> For pull_request events on a fork PR, GitHub Actions always issues a read-only GITHUB_TOKEN, regardless of what permissions: the workflow declares — this is a hard security restriction to prevent a malicious fork PR from using elevated permissions
@morten-andersen
morten-andersen merged commit 1e7a0d9 into main Aug 24, 2026
1 check passed
@morten-andersen
morten-andersen deleted the fix/NOJIRA/add-flag-to-skip-code-coverage-on-prs branch August 24, 2026 12:01
BrianEstrada pushed a commit to monta-app/ocpp-emulator that referenced this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants