feat(argocd): add argocd-wait-sync-multi action for concurrent rollout verification - #332
Merged
Merged
Conversation
…t verification Waits for many ArgoCD apps to sync and become healthy at an expected revision in one job, fails fast on Degraded/Missing/failed/diverged/timeout, and emits one aggregated per-app timing JSON. Sibling of argocd-wait-sync (untouched); reuses its per-app state machine, fail-fast conditions and supersede-via-ancestry check. Adds a source-repo input to verify multi-source apps against .status.sync.revisions[<source index>] (singular .status.sync.revision is empty on multi-source apps). Includes offline fixture tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JesperTerkelsen
marked this pull request as ready for review
August 26, 2026 05:27
JesperTerkelsen
requested review from
sudheer-monta
and removed request for
a team
August 26, 2026 05:27
cweinberger
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New composite action
argocd-wait-sync-multi— waits concurrently for many ArgoCD apps to sync and become healthy at an expected git revision, fails fast, and emits one aggregated per-app timing JSON.It's the multi-app sibling of
argocd-wait-sync(which is left untouched — it's pinned@mainby many deploy pipelines, so zero risk to them). This action reuses the same proven per-app state machine (refresh → detect our revision → wait Synced+Healthy), the same fail-fast conditions, and the same supersede-via-git-ancestry check, generalized to N apps in one job.Why
For repos where one workflow run deploys several apps (e.g. a monorepo that bumps many services in a single manifests commit), we want one job that verifies every app rolled out healthy and hands the per-app start/end timing to a downstream step (e.g. a release changelog). A single-app-in-a-matrix approach can't aggregate outputs; this can.
Key addition: multi-source support
Multi-source ArgoCD apps (
spec.sources[], e.g. a chart source + a separate manifests/image-values source) leave.status.sync.revisionempty and report one revision per source in.status.sync.revisions[]. The newsource-repoinput selects which source's revision to verify against (byrepoURLsubstring). Single-source apps omit it and use the singular field — identical toargocd-wait-sync.Outputs
deployments:[{ name, app, revision, start, end, status, url }](ISO 8601 UTC).Fail-fast
Exits non-zero the moment any app is
Degraded/Missing/ operationFailed/Error/ manifestsdiverged, or on overall timeout with any app not yet healthy. TransientUnknown(≤30s) andComparisonError(≤60s, with hard refresh) are tolerated.Tests
test/run-tests.sh) — multi-source extraction, two-phase progress→healthy, fail-fast on Degraded, single-source backward compat, input validation. Passes on bash 3.2 and 5.x;shellcheckclean.test-local.sh) for validation againstargocd.monta.app.Not in this PR
The caller wiring (monorepo-typescript
wait-rolloutjob) lands separately, after a live run + observe-only soak against real deploys.Notes for reviewers
CLAUDE.mdchangelog entry.argocd-wait-syncbehavior is unchanged (not touched). A future follow-up can refactor it to share this core.🤖 Generated with Claude Code