fix(component-deploy): emit ArgoCD deployment-url when sync wait is skipped - #335
Merged
JesperTerkelsen merged 1 commit intoAug 28, 2026
Merged
Conversation
…wait is skipped The deploy job's `deployment-url` output was sourced solely from the `argocd-sync` step, which is skipped when auto-sync is disabled on the app (`disableAutoSync: true`) or `wait-for-argocd-sync: false`. In that case the output was empty and the changelog release message lost its "Deployment" (ArgoCD) link — the revert-target pointer — even though the app URL is fully deterministic from the inputs. Add a `Resolve deployment URL` step that prefers the sync step's URL when present and otherwise derives it as `https://<argocd-server>/applications/argocd/<app>-<stage>` (v2 honours `argocd-app-name`). Guarded on a non-empty `argocd-server`, so non-ArgoCD deploys are unaffected. Timing still requires the sync wait; this only restores the link. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JesperTerkelsen
force-pushed
the
fix/argocd-deployment-url-when-sync-skipped
branch
from
August 28, 2026 15:30
54ee043 to
bc548b5
Compare
JesperTerkelsen
marked this pull request as ready for review
August 28, 2026 15:33
JesperTerkelsen
requested review from
sudheer-monta
and removed request for
a team
August 28, 2026 15:33
joscdk
approved these changes
Aug 28, 2026
JesperTerkelsen
deleted the
fix/argocd-deployment-url-when-sync-skipped
branch
August 28, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release messages for services whose ArgoCD app has auto-sync disabled (
disableAutoSync: true) or that passwait-for-argocd-sync: falsewere missing the "Deployment" (ArgoCD) link — the revert-target pointer used during incidents.Root cause: the deploy job's
deployment-urloutput came only from theargocd-syncstep (steps.argocd-sync.outputs.deployment-url). That step is gated onwait-for-argocd-sync && detect-autosync && creds, so when it's skipped the output is empty and the changelog renders no Deployment link.Fix: add a
Resolve deployment URLstep that uses the sync step's URL when present and otherwise derives the (deterministic) ArgoCD app URL from inputs:https://<argocd-server>/applications/argocd/<app>-<stage>(v2 honoursargocd-app-name). Guarded on a non-emptyargocd-serverso non-ArgoCD deploys are unchanged. Applied to bothcomponent-deploy.ymlandcomponent-deploy-v2.yml.Scope: this restores the link only. Deployment timing still requires the sync wait to run (unchanged). Affected services (auto-sync off / wait off): App API v2, Portal API, OCPP Gateway, IP, OCPP Proxy, Data Broker, Grid.
Found via an SRE audit of ArgoCD syncs vs #info-releases posts.
Ticket: https://montaapp.atlassian.net/browse/SRE-422
🤖 Generated with Claude Code