New behat phpunit options #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
============================================
+ Coverage 84.63% 85.07% +0.43%
- Complexity 694 702 +8
============================================
Files 74 74
Lines 2148 2184 +36
============================================
+ Hits 1818 1858 +40
+ Misses 330 326 -4
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
stronk7
force-pushed
the
new_behat_phpunit_options
branch
from
637ab04
to
029459a
Compare
|
IMPORTANT NOTE: This has to be merged after #255 (it's built on top of it). |
stronk7
force-pushed
the
new_behat_phpunit_options
branch
from
029459a
to
62411d5
Compare
That way we'll be able, in all the test using DummyExecute, to perform assertions against the commands executed, so we can cover options logic and so on.
Covered by tests that use intensively the new ->lastCmd introduced by the previous commit. Also, added a TODO about something, pre-existing, that is an incorrect unit tests, some day will be investigated. Not today. Fixes moodlehq#246
Covered by tests that use intensively the new ->lastCmd introduced a couple of commits ago. Also, added a TODO about something, pre-existing, that is an incorrect unit tests, some day will be investigated. Not today. Fixes moodlehq#100
stronk7
force-pushed
the
new_behat_phpunit_options
branch
from
62411d5
to
632a21f
Compare
|
This has been rebased on top of #255 , already merged. |
|
Self-merging, towards a release happening soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 3 commits:
DummyExecutein order to make the last command executed available for testing purposes.--tagsand--nameBehat options available (Add support for --tags and --name to behat runs #246).--configure,--testsuiteand--fillterPHPUnit options available (Add support for --testsuite, --config, --filter to phpunit runs #100).I've added 2
TODOsin the code about some tests that, IMO, are wrong. They are pre-existing and won't be analysed or fixed here.Ciao :-)