Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use general stylelint task in grunt command #320

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

kabalin
Copy link
Member

@kabalin kabalin commented Sep 10, 2024

This change makes use of general stylelint task in grunt command, thus let grunt task to decide whether css or scss linter needs to be run (or both).

Also cleans up deprecated stylelint:less task (removed in 3.7 at MDL-64506) in a separate commit.

Fixes #314

This has been removed in core in MDL-64506 (3.7).
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (f722b93) to head (f09b894).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #320   +/-   ##
=========================================
  Coverage     88.25%   88.25%           
- Complexity      737      738    +1     
=========================================
  Files            76       76           
  Lines          2274     2274           
=========================================
  Hits           2007     2007           
  Misses          267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

So that core grunt task will decide whether css or scss linter needs to be run (or both).

Fixes moodlehq#314
Copy link
Contributor

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kabalin! The changes make sense and look spot-on.

@junpataleta junpataleta merged commit 8d1c7df into moodlehq:main Oct 22, 2024
25 checks passed
@kabalin kabalin deleted the stylelint branch October 22, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presence of .scss file in a plugin makes moodle-plugin-ci grunt command to fail
2 participants