Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust filter plugin validation requirements to comply with Moodle 4.5 #326

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adjust filter plugin validation requirements to comply with Moodle 4.5 #326

wants to merge 2 commits into from

Commits on Oct 24, 2024

  1. Adjust filter plugin requirements to comply with 4.5. 

    Per https://moodledev.io/docs/4.5/devupdate#filter-plugins

Fixes moodlehq#321
    @kabalin
    kabalin committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8b2d4c3 View commit details
    Browse the repository at this point in the history

  2. Implement getRequiredFunctionCalls check and use it in filter plugin … 

    …validation.

This address scenario where file is supposed to contain certain function
call, such as `class_alias` in Filter plugin type backward compatibility
support per https://moodledev.io/docs/4.5/devupdate#filter-plugins

The patch makes possible for deleveloper to specify:
* getRequiredFunctionCalls to make sure file contains function call as
  name suggests.
* FileTokens::notFoundHint to give some context for requirement to improve developer experience. This works with FileTokens in any other validation methods.
    @kabalin
    kabalin committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2b36993 View commit details
    Browse the repository at this point in the history