feat: allow to ignore version check #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omerlh can you run |
|
Yeah sure! |
|
Sorry I missed this before but we don't want to be passing booleans around. I thought you were talking about an Options struct that goes on a BAI2 File, Reader, Writer, ValidateWith(...) which has an This change would be a breaking change as-is and booleans make for bad parameters. |
|
I am happy to change the code to support options parameters, but it needs to be populated from the CLI args... Also we can do that non-breaking with default values |
|
@omerlh I moved ignoreVersion to an Options struct. Thoughts? |
|
Looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #118 that's for supporting weird BAI files with wrong header 🤷