Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of provinces in Vietnam #469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donhuvy
Copy link

@donhuvy donhuvy commented Mar 15, 2021

No description provided.

@jonesde
Copy link
Member

jonesde commented May 17, 2022

The modified files (CommonL10nData.xml and CurrencyData.xml) do not include a list of Vietnam provinces, is there maybe a file missing?

Also for the currency, would it be more correct to "Viet Nam Dong" as is in this PR, or "Vietnam Dong" with a single word country name?

One last thing, for this contribution please also sign the AUTHORS file (both sections, for the CC0 copyright disclaimer, and the patent disclaimer at the bottom). For more info about that please see:

https://moqui.org/m/docs/moqui/Issue+and+Pull+Request+Guide#intellectual-property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants