Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the DLL search pattern #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mabl
Copy link

@mabl mabl commented Aug 4, 2020

This should make it discover newer versions such as the recently released Vimba 4.0, too.

This should make it discover newer versions such as
the recently released Vimba 4.0, too.
@morefigs
Copy link
Owner

morefigs commented Aug 4, 2020

Thanks, much nicer! My only hesitation is that this requires Python 3.4, which may cut off some users.

@mabl
Copy link
Author

mabl commented Aug 5, 2020

Yes, I specifically checked for the patlib library availability. But Python 3.4 is already end of life. Even Python 3.5 will be EOL in september.

@mabl
Copy link
Author

mabl commented Aug 5, 2020

The more critical thing, I just realized would be the format strings I used. That is python 3.6. Feel free to use ore modify this code as you like :-) I just ran across it when the current pymba version did not like vimba 4.

@morefigs
Copy link
Owner

morefigs commented Aug 7, 2020

Fair point on v3.4. Yes, the f-strings are still an issue for some users, if you can remove that I'll merge ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants