Centralization cleanup - #1038
Open
SegueII wants to merge 61 commits into
Open
Conversation
…h guard, metrics port) (#1034) Co-authored-by: corey <corey.zhang@bitget.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: corey <corey.zhang@bitget.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Program vkey: 0x00c684101523a06415be6d72d011eebaf465b4c1da4e3b18ab052a29d7ac6e88 ELF SHA-256: f916cf05f462c08692b28a112ecc65ae7a66e7648bdedcd264648993fa666719
feat: complete post-centralization cleanup
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: allen.wu <allen.wu@bitget.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat: allow third-party submitter staking
Co-authored-by: kukoo.yue <kukoo.yue@bitget.com>
chore(challenge-handler): opt proveState
Stop documenting blob_count_mismatch as a BatchStatus divergence, and stop wrapping ErrBatchVerifyDivergence on that packing error so the sentinel matches the call site. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore the ErrBatchVerifyDivergence wrap on blob_count_mismatch and the surrounding comment text; correct only the sentences that claimed the rebuildBlob path sets BatchStatus=stateException. Co-authored-by: Cursor <cursoragent@cursor.com>
…entinel docs(derivation): stateException is only from verifyBatchRoots
…d never rough-estimate past a revert commitBatch / commitState / finalizeBatch all carry onlyActiveSubmitter on L1, but the activity probe only ran once, in PreCheck at Start(). A submitter can be removed, slashed, priced out by a raised minimum stake, or start withdrawing at any point afterwards, and the rollup / finalize loops kept submitting against a stale startup result. With rough_estimate_gas enabled this became a funds leak rather than a stall: eth_estimateGas fails on the revert, the rough fallback swallowed that failure and guessed a gas limit, and the tx was signed and sent anyway. The reverting tx refunds unused execution gas, but a commitBatch blob tx is charged its full blob fee regardless of revert. Nothing broke the cycle — the failed receipt only logs a warning, and once the tx leaves the pending pool the loop re-derives the same batch index and resends, with no low-balance guard. - extract ensureActiveSubmitter and call it at the top of rollup() and finalize(); an RPC failure on the probe also stops submission rather than assuming the wallet is still eligible - gate both rough-estimate fallbacks on utils.IsExecutionRevertErr, so the flag still covers a flaky/unreachable node but never guesses past a contract rejection Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fix(tx-submitter): re-check submitter activity before each submit, and never rough-estimate past a revert
update go-ethereum tag
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.