fix(devnet): make local startup reliable

[SegueII]

Summary by CodeRabbit

• New Features

  • Deployment registration now derives batch submitter addresses from configured private keys when available, improving consistency across environments.
  • Devnet startup now waits for the L2 execution client to become reachable before starting the gas price oracle.

• Bug Fixes

  • Updated devnet configuration to remove reliance on legacy L1 staking settings.
  • Added safeguards to exclude generated build artifacts from Docker contexts, reducing unnecessary build input.

[claude]

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 846cf4ba-54c9-4cd5-b388-b29518cd0e54

📥 Commits

Reviewing files that changed from the base of the PR and between b1cbdd3 and a9447c5.

📒 Files selected for processing (6)

• .dockerignore
• contracts/tasks/deploy.ts
• ops/devnet-morph/devnet/__init__.py
• ops/devnet-morph/tests/test_devnet_config.py
• ops/docker/.env
• ops/docker/docker-compose-devnet.yml

💤 Files with no reviewable changes (1)

• ops/docker/.env

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The devnet deployment now uses a legacy staking proxy fallback, derives batch submitter addresses from private keys, funds before registration, removes legacy staking environment variables, waits for L2 readiness, and ignores generated build outputs.

Changes

Devnet deployment and startup

Layer / File(s)	Summary
Deployment and batch submitter setup contracts/tasks/deploy.ts, ops/devnet-morph/devnet/__init__.py	The deployment derives configured addresses from batchSubmitterPks when available. The launcher passes deployer and batch submitter keys to fund and register, and sets the legacy staking proxy address.
Launcher and environment lifecycle ops/devnet-morph/devnet/__init__.py, ops/devnet-morph/tests/test_devnet_config.py	The launcher runs fund before register, removes legacy staking variables, and raises on failed L1 or L2 commands. Tests validate these changes.
Service readiness and output exclusions ops/docker/docker-compose-devnet.yml, .dockerignore, ops/docker/.env, ops/devnet-morph/tests/test_devnet_config.py	The gas-price oracle waits for morph-el-0:8545. Docker no longer stores the legacy staking variable and ignores generated build outputs. Tests validate the configuration.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🔵 Low · up to a9447

The PR improves local devnet startup ordering and failure handling, but a registration failure can still leave an apparently completed environment without the intended submitter authority, and the supplied submitter key controls which account is funded and registered. The change is mergeable with explicit owner awareness and follow-up on failure propagation and partial-startup recovery.

Sequence Diagram(s)

sequenceDiagram
  participant L2ExecutionClient as morph-el-0
  participant GasPriceOracle as gas-price-oracle
  participant OracleApp as ./app
  GasPriceOracle->>L2ExecutionClient: Poll TCP port 8545
  L2ExecutionClient-->>GasPriceOracle: Accept connection
  GasPriceOracle->>OracleApp: Start application

Loading

Suggested reviewers: dylancai9, panos-xyz, tomatoishealthy

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary changes, which improve local devnet startup reliability through startup ordering, service readiness checks, and removal of the legacy staking flow…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title clearly and concisely describes the primary changes, which improve local devnet startup reliability through startup ordering, service readiness checks, and removal of the legacy staking flow.

Full details: Docstring Coverage

Explanation

Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-devnet-up

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}