Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satistical tests reorganization #92

Merged

Conversation

AgnesBaud
Copy link
Member

@AgnesBaud AgnesBaud commented Mar 10, 2022

Description

  • statistical tests in both statistical_test.py and differential_analysis.py
  • SeriesBinning: bin into equal-size bins (in addition to equal-width)

Changelogs

  • reorganization Chi2 and other statistical tests
  • SeriesBinning: to put series into bins

Issue(s)

Fixes #91

Definition of Done

  • New code is tested with unit tests
  • Documentation has been updated
  • Pull Request has been revised by a maintainer of the project

@AgnesBaud AgnesBaud added the architecture structure of the project label Mar 10, 2022
@AgnesBaud AgnesBaud self-assigned this Mar 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5946124) 65.15% compared to head (cdffb0c) 66.25%.
Report is 18 commits behind head on master.

Files Patch % Lines
moonstone/analysis/statistical_test.py 95.62% 6 Missing ⚠️
moonstone/utils/pandas/series.py 95.55% 2 Missing ⚠️
moonstone/plot/graphs/bargraph.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   65.15%   66.25%   +1.10%     
==========================================
  Files          61       61              
  Lines        2930     3020      +90     
==========================================
+ Hits         1909     2001      +92     
+ Misses       1021     1019       -2     
Flag Coverage Δ
unittests 66.25% <95.69%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AgnesBaud AgnesBaud marked this pull request as draft March 10, 2022 12:40
@AgnesBaud AgnesBaud marked this pull request as ready for review February 13, 2024 14:42
@AgnesBaud AgnesBaud merged commit 85afc8d into master Feb 13, 2024
6 checks passed
@AgnesBaud AgnesBaud deleted the 90-reorganization-for-module-architectural-consistency branch February 13, 2024 14:45
@AgnesBaud AgnesBaud changed the title Reorganization for module architectural consistency Satistical tests reorganization Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture structure of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing redundancy between statistical_test/differential_analysis
2 participants