Added delete test #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @vishalda! What happens when you try to delete a non existent item? Should we not test that too? 🤔 |
|
Also, please sign your commits so I can merge them once ready. Check this tutorial out https://docs.github.com/articles/about-gpg/ |
GabrielCTroia
added
good first issue
|
@GabrielCTroia I was trying to remove non-existent data but there were no errors after doing that operation, is this the normal behavior of remove method? |
|
Hmm, the interface expects to return a but the implementation skipped over that from what it seems: Would you like to implement that too? If not I can open another issue. Thank you! |
|
Yes I would like to try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #45