Bug 1238595 syntaxerror in compressed jquery ui #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -260,7 +260,7 @@ | |||
| 'source_filenames': ( | |||
| 'crashstats/js/socorro/exploitability.js', | |||
| ), | |||
| 'output_filename': 'js/.min.js', | |||
| 'output_filename': 'js/exploitability.min.js', | |||
|
I'm confused, I've been unable to reproduce the problem we saw on stage locally. But this works, and given the link you gave, I believe it will fix the issue. So, let's go with it! |
adngdb
added a commit
that referenced
this pull request
Jan 12, 2016
…ressed-jquery-ui Bug 1238595 syntaxerror in compressed jquery ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adngdb So yuglify has a bug that can't handle certain jquery files. And sadly yuglify uses the old UglifyJS and not UglifyJS2. Switched fixed the problem.
What
yuglifywas was a wrapper overcssminand (the old)uglifyjs. So instead of keeping it, I decided it's better we just use explicitlycssminand (the new)uglifyjs.Yeah, it's confusing. Compare: uglify-js and uglify.
Also, this was confusing