Skip to content

Upgrade to Uniffi 0.32 - #7555

Open
bendk wants to merge 2 commits into
mainfrom
bdk/push-vzynnoquttku
Open

Upgrade to Uniffi 0.32#7555
bendk wants to merge 2 commits into
mainfrom
bdk/push-vzynnoquttku

Conversation

@bendk

@bendk bendk commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk
bendk requested a review from a team as a code owner August 19, 2026 15:30
@bendk
bendk requested review from mashalifshin and removed request for a team August 19, 2026 15:30
@bendk bendk added WIP Work in progress ☢️ Do not merge labels Aug 19, 2026
Comment thread components/places/Cargo.toml Outdated
@bendk
bendk force-pushed the bdk/push-vzynnoquttku branch 15 times, most recently from 0f744e7 to 3956f1b Compare August 20, 2026 20:16
@badboy

badboy commented Aug 31, 2026

Copy link
Copy Markdown
Member

you should be able to pull in badboy@7cb27dc for the glean update

@bendk
bendk force-pushed the bdk/push-vzynnoquttku branch 2 times, most recently from 99442e5 to 1f9ace3 Compare August 31, 2026 18:57
@bendk

bendk commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

you should be able to pull in badboy@7cb27dc for the glean update

Thanks. I reordered the commit to put your one first, since I think that'll make the branching easier.

@bendk
bendk force-pushed the bdk/push-vzynnoquttku branch 2 times, most recently from cbd8090 to 27d5b7d Compare August 31, 2026 19:06
@bendk
bendk force-pushed the bdk/push-vzynnoquttku branch from 27d5b7d to 81363f6 Compare August 31, 2026 19:25
@badboy

badboy commented Sep 1, 2026

Copy link
Copy Markdown
Member

failure in run-tests-min-supported-version:

error: rustc 1.90.0 is not supported by the following packages:
  cargo-platform@0.3.3 requires rustc 1.91
  cargo-platform@0.3.3 requires rustc 1.91

fixed by a downgrade:

cargo update -p cargo-platform --precise 0.3.2

@badboy

badboy commented Sep 1, 2026

Copy link
Copy Markdown
Member

failure in ios-artifacts

Unknown namespace for Enum(EnumMetadata { module_path: "glean_sym::types", name: "ErrorType", orig_name: None, shape: Enum, remote: false, variants: [VariantMetadata { name: "InvalidValue", orig_name: None, discr: None, fields: [], docstring: None }, VariantMetadata { name: "InvalidLabel", orig_name: None, discr: None, fields: [], docstring: None }, VariantMetadata { name: "InvalidState", orig_name: None, discr: None, fields: [], docstring: None }, VariantMetadata { name: "InvalidOverflow", orig_name: None, discr: None, fields: [], docstring: None }], discr_type: None, non_exhaustive: false, docstring: None }) (glean_sym)

this requires the active feature on glean-sym activated:

glean-sym = { version = "70", features = ["active"] }

in megazords/ios-rust/Cargo.toml.
And probably also in megazords/full/Cargo.toml (pulling that from #7468)

@badboy

badboy commented Sep 1, 2026

Copy link
Copy Markdown
Member

failure run-tests

Conflicting metadata types:
old: CustomTypeMetadata { module_path: "nimbus_fml", name: "JsonObject", orig_name: None, builtin: String, docstring: None }
new: CustomTypeMetadata { module_path: "nimbus_fml::client", name: "JsonObject", orig_name: None, builtin: String, docstring: None }

fixable by not making the ffi module pub in components/places/src/lib.rs:

Edit: My previous suggesting doesn't seem to work actually.

Edit 2: The fix is to move the custom type definitions to the top-level, see 5d99b44

all changes in the branch: main...badboy:application-services:fixes/bdk/push-vzynnoquttku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants