Refresh time_last_modified when an address is updated - #7569
Merged
Conversation
update_address wrote the content columns but left time_last_modified at its creation value, unlike update_credit_card and update_passport. The field is uploaded in the outgoing sync payload and read by consumers such as Firefox Desktop, so a stale value makes a freshly edited address look untouched. It does not decide sync conflicts -- address content is merged field-by-field against the mirror -- so this changes what the timestamp reports, not which record wins.
jo
approved these changes
Aug 31, 2026
Contributor
|
btw I just opened this pr, which sanitizes timestamps - maybe a similar thing would help here, too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_address wrote the content columns but left time_last_modified at its creation value, unlike update_credit_card and update_passport.
Pull Request checklist
[ci full]to the PR title.