Fix compatibility warning with nixpkgs >= NixOS 24.11 #332
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
nixpkgs-unstable
or NixOS 24.11 (not released as of writing), using the rust overlay leads to the following deprecation warning:Note that in my case, the warning is indeed repeated six times.
The reason why this happens can be seen in this particular release note:
https://github.com/NixOS/nixpkgs/blob/7881fbfd2e3ed1dfa315fca889b2cfd94be39337/nixos/doc/manual/release-notes/rl-2411.section.md#L293
Since this repo only ever calls
rust.toRustTarget
, that is the only thing that needs migrating.Note that the
toRustTargetCompat
should make sure that the overlay keeps working, even if one is running an older version of Nixpkgs. This seems useful for users of the overlay, as otherwise just updatingnixpkgs-mozilla
without updatingnixpkgs
would cause a rather complex evaluation error.