Object3D: minimize rotation-quaternion conversions #29108
Draft
+329
−571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
| @@ -28,6 +28,36 @@ const _removedEvent = { type: 'removed' }; | |||
| const _childaddedEvent = { type: 'childadded', child: null }; | |||
| const _childremovedEvent = { type: 'childremoved', child: null }; | |||
|
|
|||
| function listenToProperties( object, properties, onReadCallback, onWriteCallback ) { | |||
There was a problem hiding this comment.
This could be moved to math classes' getters/setters, but I thought inlining here would make them easier to maintain.
Most of the diff from this PR is removing the indirection and callbacks from math classes.
| get x() { | ||
| get _x() { |
There was a problem hiding this comment.
_x, _y, _z fields etc. are preserved as getters/setters to not break user code (library code no longer references these).
If these are considered internal, we can exclude them without deprecation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaks up rotation/quaternion optimizations from #28534, where the conversion is only performed both when data has changed and on the next read if at all (instead of unconditionally on member write which may be much higher frequency).