We have seen cases where verify_ip fails on ipv4 vs ipv6 expression of localhost #71
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maparent
force-pushed
the
conflicting_localhost
branch
from
c50e9ff
to
5207cf7
Compare
ERROR:tornado.general:Attempted to attach to session 7ceo057h (::1) from different IP (127.0.0.1) ERROR:tornado.general:Attempted to attach to session 60qsy81d (127.0.0.1) from different IP (::1) Normalize the ipv6 to ipv4 expression of localhost.
maparent
force-pushed
the
conflicting_localhost
branch
from
5207cf7
to
445f0ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eg from our stderr:
ERROR:tornado.general:Attempted to attach to session 7ceo057h (::1) from different IP (127.0.0.1)
ERROR:tornado.general:Attempted to attach to session 60qsy81d (127.0.0.1) from different IP (::1)
I do a simple normalization to the ipv4 version: I'm sure something smarter could be done.
This is at least a way to pinpoint the issue.