Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose as nodejs component & fix dropdown bug & add multiple letter type suggestions #58

Merged
merged 4 commits into from
Sep 26, 2019

Conversation

jschneier
Copy link
Contributor

Hi this enables me to require this package on the server.

@jschneier jschneier force-pushed the master branch 2 times, most recently from 14fe1e4 to 12d422a Compare August 28, 2018 21:58
@jschneier jschneier changed the title Expose as nodejs component Expose as nodejs component & fix dropdown bug Aug 29, 2018
@jschneier
Copy link
Contributor Author

Without the e.preventDefault() my dropdown would always close.

@jschneier
Copy link
Contributor Author

The 3rd commit closes #56.

@jschneier jschneier changed the title Expose as nodejs component & fix dropdown bug Expose as nodejs component & fix dropdown bug & add multiple letter type suggestions Aug 29, 2018
@jschneier jschneier changed the title Expose as nodejs component & fix dropdown bug & add multiple letter type suggestions Expose as nodejs component & fix dropdown bug & add multiple letter type suggestions & make showdropdown public Sep 3, 2018
@jschneier jschneier changed the title Expose as nodejs component & fix dropdown bug & add multiple letter type suggestions & make showdropdown public Expose as nodejs component & fix dropdown bug & add multiple letter type suggestions Sep 3, 2018
@mrmarkfrench
Copy link
Owner

Thanks for your contribution!

If you'd please re-minify this change to prevent conflicts with updates from other pull requests, we'll get this one merged in and available.

@mapreal19
Copy link

any updates here?

@mrmarkfrench
Copy link
Owner

It's still showing merge conflicts, so not able to merge this pull request without an update.

@jschneier
Copy link
Contributor Author

@mrmarkfrench I have rebuilt this off a rebase, please merge. It applied cleanly when I opened this PR originally.

@mrmarkfrench mrmarkfrench merged commit 13153ba into mrmarkfrench:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants