Feature/docker #17
Merged
Feature/docker #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ adding dockerfile
✔️ locking numpy version as newer versions clash with currently locked pandas version ✔️ fixing some formatting in setup.py
python 3.5 and 3.6 are unstable versions, cutting support
incorrect method being used
✔️ previous test had depreciated ✔️ suspect handling of NA fill
rhshah
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need a docker image of this tool. This will help use it in containerized workflows such as cci traceback.
This PR:
NAfill not working as expected: https://github.com/msk-access/genotype_variants/pull/17/files#diff-4a5e04e8ab5dfb5548dd4f0323c58d2af8e13406ff6231d7763dd8f59f53b2b1