Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsl2/filter sv blacklist #965

Merged
merged 28 commits into from
Jul 25, 2022
Merged

Conversation

anoronh4
Copy link
Collaborator

@anoronh4 anoronh4 commented Jul 7, 2022

Improvements to filtering:

  • Added bed/bedpe files used by pcawg to filter results:
    • svBlacklistBed
    • svBlacklistBedpe
    • svBlacklistFoldbackBedpe
    • svBlacklistTEBedpe
  • svBlacklist* files from above are sourced from pcawg_sv_merge data files. Their usage was modeled after the pcawg6_sv_merge_master.sh script from the same repo.
  • parallelized iAnnotateSV, and defined resource configuration of .*AnnotateSVBedpe processes to improve runtime.
  • Fixed header of bedpe, because svtools misreads certain lines with special characters, issue made here: bedpetovcf does not work with vcftobedpe output as input hall-lab/svtools#324
  • The filtering scripts pair_to_pair_annot.py and pair_to_bed_annot.py converged into and were replaced by filter_regions_bedpe.py. The name change makes the intention of the script more obvious.
  • added print statements and exception handling to python scripts to improve logging/debugging.

@anoronh4 anoronh4 requested a review from gongyixiao July 12, 2022 18:41
@gongyixiao
Copy link
Collaborator

gongyixiao commented Jul 20, 2022

Suggestion: You might want to put signatures on codes which written by you @anoronh4 . Up to you.

conf/references.config Show resolved Hide resolved
containers/iannotatesv/run_iannotatesv.py Outdated Show resolved Hide resolved
@gongyixiao
Copy link
Collaborator

Why am I seeing both filter_regions_bedpe.py and pair_to_pair_annot.py in the container folder together and they are not the same? And what was the file pair_to_bed_annot.py which is deleted here?

@gongyixiao gongyixiao added the enhancement New feature or request label Jul 20, 2022
@gongyixiao gongyixiao added this to the 2.0 milestone Jul 20, 2022
@anoronh4
Copy link
Collaborator Author

anoronh4 commented Jul 22, 2022

Why am I seeing both filter_regions_bedpe.py and pair_to_pair_annot.py in the container folder together and they are not the same? And what was the file pair_to_bed_annot.py which is deleted here?

pair_to_pair_annot.py and pair_to_bed_annot.py were supposed to have converged into and been replaced by filter_regions_bedpe.py. I forgot to remove pair_to_pair_annot.py. it's now removed and i changed the PR summary to better describe the changes.

Suggestion: You might want to put signatures on codes which written by you @anoronh4 . Up to you.

Will do!

@anoronh4 anoronh4 merged commit 2d4e831 into dsl2/enhancement/WGS_SV Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants