fix: resolve remaining RustSec advisories - #16
Merged
Conversation
Update anyhow, crossbeam-epoch, h2, memmap2, and the tokio-postgres dependency family to patched releases admitted by the existing manifest constraints. Verified: cargo fmt --all -- --check; cargo clippy --all-targets --all-features -- -D warnings; cargo test --all-features (92 passed, 1 ignored); cargo audit (0 vulnerabilities).
Move to the first release containing the Remote::list and BlameHunk signature safety fixes. Treat a missing blame signature as an error instead of dereferencing it. TDD: the missing-signature regression failed before the helper existed and now passes. Verified: cargo fmt --all -- --check; cargo clippy --all-targets --all-features -- -D warnings; cargo test --all-features (93 passed, 1 ignored); cargo audit (0 vulnerabilities, only the pending lru unsoundness advisory).
Pin the upstream Tantivy commit that moves its lru dependency to 0.18.2, the first release with the panic-safety fix. The selected revision is immutable and its documented 0.27 API change is not used by Code Memory. Verified: cargo check --all-features; cargo fmt --all -- --check; cargo clippy --all-targets --all-features -- -D warnings; cargo test --all-features (93 passed, 1 ignored); cargo audit (0 vulnerabilities, 0 unsound warnings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyhow,crossbeam-epoch,h2,memmap2, and thetokio-postgresdependency family to patched compatible releasesgit2to 0.21 and safely reject blame hunks without a final signaturelruto the first panic-safe releaseSecurity result
The pre-change RustSec scan found 5 vulnerabilities and 5 unsoundness advisories. The final scan reports:
Four informational unmaintained notices remain (
core2,instant,number_prefix, andpaste). RustSec lists no patched releases for them; each is transitive throughfastembedornotify, not a direct dependency.Verification
cargo fmt --package code-memory -- --checkcargo clippy -- -D warningscargo clippy --all-targets --all-features -- -D warningscargo testwith the CI PostgreSQL schema andTEST_DATABASE_URL(93 passed, 1 intentionally ignored)cargo test --all-features(93 passed, 1 intentionally ignored)cargo build --release --all-featurescargo audit(0 vulnerabilities, 0 unsoundness advisories)npm ci --ignore-scriptsnpm run checknpm exec -- ultracite doctor(4 passed, 0 warnings, 0 failed)npm audit --audit-level=high(0 vulnerabilities)npm packartifact inspection (5 expected files)TDD evidence: the missing-blame-signature regression failed before the compatibility helper existed, then passed after the
git20.21 migration.