Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anne pro Caps Lock fully working #5

Open
wants to merge 579 commits into
base: anne_pro
Choose a base branch
from
Open

Anne pro Caps Lock fully working #5

wants to merge 579 commits into from

Conversation

jesusvallejo
Copy link

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

msvisser
msvisser requested changes Jul 19, 2019
View reviewed changes
Copy link
Owner

@msvisser msvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you very much for wanting to contribute!

I have quite some comments on the code you submitted, as some parts of the code are unclear to me. Please give me some insight into the reasons for some of the code. If we can work out those things I would be happy to merge this contribution!

keyboards/anne_pro/anne_pro.c Outdated Show resolved Hide resolved
keyboards/anne_pro/anne_pro_lighting.c Outdated Show resolved Hide resolved
keyboards/anne_pro/anne_pro_lighting.c Outdated Show resolved Hide resolved
keyboards/anne_pro/anne_pro_lighting.c Outdated Show resolved Hide resolved
keyboards/anne_pro/anne_pro_lighting.c Outdated Show resolved Hide resolved
keyboards/anne_pro/anne_pro_lighting.c Outdated Show resolved Hide resolved
keyboards/anne_pro/anne_pro_lighting.c Outdated Show resolved Hide resolved
@msvisser msvisser self-assigned this Jul 19, 2019
@jesusvallejo
Copy link
Author

Made some changes as per requested :)

@msvisser
Copy link
Owner

I have tested out the requested changes, however I still experience some bugs with just a few minutes of testing. For example if I turn the backlight on, then capslock on and then backlight off, capslock also turns off, although it is still enabled. The problem is that nothing keeps track of when the lighting controller can be put to sleep, so the controller is put to sleep when the backlight is disabled.

@msvisser msvisser mentioned this pull request Jul 23, 2019
Closed
@msvisser
Copy link
Owner

msvisser commented Jul 23, 2019 •
edited
Loading

I have opened a PR #7 which shows my WIP implementation, which fixes some of the bugs with your implementation, however still contains some problems.

@jesusvallejo
Copy link
Author

jesusvallejo commented Jul 23, 2019 •
edited
Loading

Ok then, moving Caps Lock development and testing into PR #7. After testing #7 i can say that #5 is more stable after the last commit.

@jesusvallejo jesusvallejo reopened this Jul 23, 2019
@jesusvallejo
Copy link
Author

jesusvallejo commented Jul 23, 2019 •
edited
Loading

  • Works with backlight on.
    - When act/deact from anne pro.
    - When act/deact from other system kb.
    - When LT(1,KC_CAPS) is used in keymaps.
    - When KC_CAPS is used in keymaps.
    - When going from backlight on to backlight off.

  • Works with backlight off.
    - When act/deact from anne pro.
    - When act/deact from other system kb.
    - When LT(1,KC_CAPS) is used in keymaps.
    - When KC_CAPS is used in keymaps.
    - When going from backlight off to backlight on.

  • Works if activated in system prior to boot.

@msvisser
Copy link
Owner

I'm sorry that it has taken me so long to get back to you.
I have tried your newest version and it is indeed better, however I still have the backlight turning on when pressing capslock sometimes. So I am not quite sure if I want to merge these changes.

Also there are a number of changed files in this pull request that are unrelated to the capslock feature. Please remove these change, otherwise I will not be able to merge the changes.

@jesusvallejo
Copy link
Author

jesusvallejo commented Nov 28, 2019 •
edited
Loading

I'm sorry that it has taken me so long to get back to you.
I have tried your newest version and it is indeed better, however I still have the backlight turning on when pressing capslock sometimes. So I am not quite sure if I want to merge these changes.

Also there are a number of changed files in this pull request that are unrelated to the capslock feature. Please remove these change, otherwise I will not be able to merge the changes.

Hi , i removed those last commits , i know it is still far from perfect , from now on ill only update my fork in the capslock area, ive tryed a lot of different ways and still this is the one that works the best, until its working correctly i think u should not merge it , any way i think the problem is related to the leds firmware and how the uart works, mby it would be better to implement the light.bin also but dont know how or if it is even posible.

@jesusvallejo
Copy link
Author

  • Works with backlight on.
    - When act/deact from anne pro.
    - When act/deact from other system kb.
    - When LT(1,KC_CAPS) is used in keymaps.
    - When KC_CAPS is used in keymaps.
    - When going from backlight on to backlight off.

  • Works with backlight off.
    - When act/deact from anne pro.
    - When act/deact from other system kb.
    - When LT(1,KC_CAPS) is used in keymaps.
    - When KC_CAPS is used in keymaps.
    - When going from backlight off to backlight on.

  • Works if activated in system prior to boot.

BUGS

  • Leds is still on when kb usb is disconected and reconnected via bluetooth, no matter if backlight is on or off
  • Sometimes backlight turns on when caps is act/deact

fauxpark and others added 17 commits August 29, 2020 14:30
@fauxpark @noroadsleft
Remove iWRAP protocol (qmk#9284)
5cc3ab3
@tzarc @noroadsleft
Initial work for consolidation of ChibiOS platform files (qmk#8327)
385d49c 
* Initial work for consolidation of board files and default ChibiOS configs.

* Migrate F401/F411 black pills for testing.

* Add early init bootloader jump flag.

* Add support for I2C in order to use i2c_scanner keymap.

* Add F401/F411 HSE bypass to get things booting.

* Exempt "hooked" ChibiOS conf files from updater script.

* Fix up ordering for bootloader_defs file check.

* Match previous $(KEYBOARD_PATHS) value for Proton-C, updated for all board configs.
@fauxpark @noroadsleft
Various tidyups for USB descriptor code (qmk#9005)
f209f91
@fauxpark @noroadsleft
Convert CONSUMER2BLUEFRUIT() and CONSUMER2RN42() macros to static…
1193e45 
… inline functions (qmk#9055)
@tzarc @noroadsleft
Attempt to fix CI for non-master branches. (qmk#9308)
a3933bd
@fauxpark @noroadsleft
Additional cleanups for V-USB code (qmk#9310)
69e0ad1
@fauxpark @noroadsleft
Remove inclusion of adafruit_ble.h from ssd1306.c (qmk#9355)
e7434c8
@fauxpark @noroadsleft
Don't compile outputselect.c if Bluetooth is disabled (qmk#9356)
3b34858
@tzarc @noroadsleft
qmk cformat on develop (qmk#9501)
60e5733
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (qmk#9023)
8a4a0c2 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
@tzarc @noroadsleft
Add support for DMAMUX-capable MCU configuration with WS2812 PWM driv…
c6b7a0d 
…er. (qmk#9471)
@tzarc @noroadsleft
F303/Proton-C migration. (qmk#9315)
86e30c2
@dhong44 @noroadsleft
Fix the mousekey scrolling (qmk#9174)
d0abad2 
Mousekey scrolling should have a separate repeat variable
to keep track of scrolling acceleration, instead of being
tied to mouse movement scolling in mousekeys. The send function
should record when the last movement was made since this is
when movement is actually sent. Doing this fixes the bug where
the initial press of a mousekey scroll button causes a double scroll.

Signed-off-by: Daniel Hong <daniel.hong@live.com>
@tzarc @noroadsleft
Add dual-bank STM32 bootloader support, given GPIO toggle on BOOT0 to…
93e7a8f 
… charge RC circuit. (qmk#8778)
@sevanteri @noroadsleft
Bigger combo index (qmk#9318)
b0335b2 
* Add change log

* Change combo index from uint8_t to uint16_t
@tzarc @noroadsleft
Re-fix the STM32 dual-bank bootloader stuff. (qmk#9738)
686a9d3 
* Re-fix the dual-bank bootloader stuff.

* Use wait_ms() instead of using nop's for a delay, as ChibiOS is actually running at the time of bootloader jump.
@drashna @fauxpark @noroadsleft
Disable NKRO on V-USB controllers (qmk#9054)
3c74edb 
* Disable NKRO on V-USB controllers

* not _currently_ supported text

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
gooberpsycho and others added 30 commits September 23, 2020 19:32
@gooberpsycho
[Keyboard] add 3dp660 handwired (qmk#10296)
30ffae2 
* Create keymap.c

* Add files via upload

* Added files for handwired 3d printed clueboard 660

* create via layout files

* added layout files for via

* updated product ID to fix id conflicts

* change product ID to fix ID conflicts.

* fixed capitalization error that was causing issues

* fixed capitalization issues.

* fix syntax errors

* Fixed syntax errors (stray punctuation)

* Compatibility fixes

* Compatibility fixes

* Compatibility fixes

* Compatibility fixes

* capitalization fixes

* Compatibility fixes

* Compatibility fixes

* Compatibility Fixes

* Compatibility fixes

* Compatibility fixes

* Compatibility changes

* upkeep, fixing typos

* Update keyboards/handwired/3dp660/config.h

Removed Description line

* Update keyboards/handwired/3dp660/rules.mk

correct bootloader

* Update keyboards/handwired/3dp660/3dp660.h

fix case sensitive typos

* Update keyboards/handwired/3dp660/keymaps/default/keymap.c

change tab indentation to space indentations.

* Update keyboards/handwired/3dp660/keymaps/via/keymap.c

change tab indentations to space indentations

* Delete 3dp660.json

This file was for VIA, and shouldn't be in this repo. I placed it here so I wouldn't misplace it in my filesystem. My apologies.

* Update info.json

change suggestions to other file said to lowercase "ansi", caused reference issues, changed all instances of "ANSI" to "ansi".

* Update keymap.c

change suggestions to other file said to lowercase "ansi", caused reference issues, changed all instances of "ANSI" to "ansi".

* Update keymap.c

more capitalization fixes

* Update keyboards/handwired/3dp660/readme.md

shortened imgur url

* Update keyboards/handwired/3dp660/rules.mk

remove extraneous comments

* Delete config.h

* Update keyboards/handwired/3dp660/rules.mk

* Update 3dp660.c

add license headers to all .c and .h files

* Update 3dp660.h

added license header to all .c and .h files.

* Update keymap.c

added license header to all .c and .h files.

* Update keymap.c

added license header to all .c and .h files.

* Update keyboards/handwired/3dp660/readme.md

Add maintainer URL

* Update keyboards/handwired/3dp660/keymaps/default/keymap.c

remove extraneous default keymap layers

* Update keyboards/handwired/3dp660/keymaps/default/rules.mk

* Update rules.mk

Moved LTO to keyboard level.

* Update rules.mk

Moved LTO to keyboard level.

* Delete rules.mk

Made obsolete by LTO move to keyboard level.

* Update keyboards/handwired/3dp660/rules.mk

capitalization errors.

* Apply suggestions from code review

Housekeeping, changing code for readability.
@mrsendyyk
Add ai03/soyuz VIA Support (qmk#10336)
ec7ce15 
* Add ai03/soyuz:via

* Update config.h

* Update keymap.c

* Revert "Update keymap.c"

This reverts commit e3766b3.

* Update keymap.c

* Update keymap.c

* Update keyboards/ai03/soyuz/config.h
@qmk-bot
format code according to conventions [skip ci]
860deb7
@mechmerlin
VIA Support: Gray Studio HB85 (qmk#10329)
cd64425 
* edit vid and pid

* add VIA keymap

* add my name to the readme

* Update keyboards/gray_studio/hb85/keymaps/via/config.h

* we have a third endpoint, no need to disable mousekeys

* Update keyboards/gray_studio/hb85/keymaps/via/keymap.c

* add license header
@MudkipMao @drashna @noroadsleft
Adding Bear 65 Ergo Keyboard To QMK (qmk#10384)
9c596c1 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@noroadsleft
Add Wyvern Keyboard (qmk#10378)
086c9c7 
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@fauxpark
CLI/Doctor: Print QMK_HOME (qmk#10398)
5f23f21
@mrnoisytiger
[Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394)
4511201 
* Modifed for BKS65

* Added test board

* attempts

* Working compile

* updated rules for processor frequency and documented

* Disabed some deprecated features

* Removed extraneous code

* remove test code

* Renamed board

* LED and layer code

* Added via support

* Update keyboards/fjlabs/bolsa65/bolsa65.c

Fixed indentation as suggested.

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous defaults

* Update keyboards/fjlabs/bolsa65/keymaps/default/keymap.c

Different layer enumeration method

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

New layer enumeration method.

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous description.

* Update keyboards/fjlabs/bolsa65/keymaps/via/rules.mk

Removed extraneous bootmagic

* Update keyboards/fjlabs/bolsa65/rules.mk

Updated rules

* Update keyboards/fjlabs/bolsa65/readme.md

Markdown list formatting

* Update keyboards/fjlabs/bolsa65/bolsa65.h

Changed layout name

* Update keyboards/fjlabs/bolsa65/info.json

Changed layout name

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

Changed Layout name

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

Change layout name

* Changed layout names

* Updated readme to reflect new keyboard name

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous code

* Added license file header

* Removed VSCode folder

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

* Update keyboards/fjlabs/bolsa65/info.json

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c
@drashna
Fix Belgian sendstring file (qmk#10443)
9570b1b 
Specifically, the `BE_CIRC` is an alt-ed keycode, which means it 
doesn't fit into the 8 bit keycode range...  It should be `BE_SECT`,
as it is already alt-ed by the alt lut.

Confirmed that this change fixes compilation warnings and works 
correctly, on reddit. 
https://www.reddit.com/r/olkb/comments/iywin1/unsigned_conversion_from_int_to_unsigned_char/g6jvfgl/
@doodboard
[Keyboard] add duckboard by doodboard (qmk#10318)
4a83021 
* Adding duckboard to QMK

Adding duckboard support to QMK

* added duckboard under doodboard

* changed debouncing delay to debounce

* Update keyboards/doodboard/duckboard/config.h

* Update keyboards/doodboard/duckboard/config.h

* Update keyboards/doodboard/duckboard/kb.h

* Update keyboards/doodboard/duckboard/keymaps/default/keymap.c

* Update keyboards/doodboard/duckboard/rules.mk

* Update keyboards/doodboard/duckboard/kb.h

* Update keyboards/doodboard/duckboard/kb.c

* Update code per review

Update code per review

* folder name errod

folder name errod

* Update keyboards/doodboard/duckboard/config.h

* Update keyboards/doodboard/duckboard/rules.mk

* Update keyboards/doodboard/duckboard/rules.mk

* Update keyboards/doodboard/duckboard/config.h

* Create info.json

* Update keyboards/doodboard/duckboard/duckboard.h

* Update keyboards/doodboard/duckboard/info.json

* Update keyboards/doodboard/duckboard/info.json

* Update keyboards/doodboard/duckboard/duckboard.h

* Update keyboards/doodboard/duckboard/readme.md
@jackytrabbit
Add VIA support for lazydesigners/the30 (qmk#10374)
603c8d1 
* Create rules.mk

* Add files via upload

* Update keyboards/lazydesigners/the30/keymaps/via/keymap.c
@fauxpark
Fix Belgian sendstring properly (qmk#10444)
b6f9ca3
@mechlovin
[Keyboard] add hannah65 by Team Mechlovin (qmk#10284)
c4cc697 
* add hannah65

* add iso layout, ansi layout

* Update readme.md

* add mechlovin9

* update

* update

* update

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/readme.md

* Update keyboards/mechlovin/hannah65/readme.md

* Update keyboards/mechlovin/hannah65/rev1/info.json

* Update keyboards/mechlovin/hannah65/rev1/info.json

* Update keyboards/mechlovin/hannah65/rev1/rev1.h

* Update keyboards/mechlovin/hannah65/rev1/rev1.h

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* update

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json

* Update keyboards/mechlovin/hannah65/mechlovin9/info.json
@evyd13
[Keyboard] add Percent Canoe Gen2 (qmk#10344)
1b7101f 
* Add Canoe Gen2

* Fix info.json

* Update info.json

* Changes

* Move canoegen2 to canoe_gen2

* Update canoe_gen2.h
@fauxpark
setrgb(): Use arrow operator (qmk#10451)
c16ee22
@precondition @ridingqwerty
[Docs] Wording & formatting changes in the Tapping Force Hold section…
28ff511 
… of the Tap Hold page + removed trailing whitespaces (qmk#10391)

* Wording & formatting changes in Tapping Force Hold

The Permissive Hold and the Ignore Mod Tap Interrupt sections were also modified to remove the quotes
around "tapping".

* Removed all trailing whitespaces from tap hold doc

* "it's simply really:" → "it's simple really:"

* "This allows to keep the ability" → "This allows keeping the ability"

Used the gerund form of "to keep" in the Tapping Force Hold section of the Tap Hold docs.

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>

Co-authored-by: ridingqwerty <george.g.koenig@gmail.com>
@2Moons-JP
Trifecta Keymap
323c6df
@fauxpark
Add logic for AT90USBxx7 where needed (qmk#10203)
70fce65
@fauxpark
Consolidate udev rules into a single file (qmk#9693)
e7acd39 
* Consolidate udev rules into a single file

* Update rules in doctor.py

* Simplify doctor rule checking

* Fix errors

* Add TMK "FEED" VID to list of deprecated udev rules

* A comma would be nice

* Split rules back up into bootloaders

* Link to docs page in "missing" case

* Add Pololu VID

* Be more specific about Caterina devices, and add LilyPad PID
@zvecr
[keyboard] Add SP-111 support (qmk#10193)
50835bb 
* Initial sp111 support

* Align with template
@ridingqwerty @worldspawn00
Keyboard update: SL40 (qmk#10445)
34b9c51 
* adding alpha variants

* adding cajal layouts

* adding V2 PCB support

adding additional layouts for new PCB version, and correecting incorrect image in info file

* Cleanup master -- remove alpha9

* Cleanup master -- remove g4m3ralpha

* Cleanup master -- remove cajal & sl40

* Master cleanup -- re-add sl40

* Master cleanup -- correct SL40 image

* Keyboard addenda: Production version of sl40

Co-authored-by: worldspawn00 <mcmancuso@gmail.com>
@drashna
[Keyboard] Add PloopyCo devices (qmk#7935)
fbdc65e 
* Initial Commit for Ploopyco Trackball

This is a WIP at this point.  Most of it compiles, but the SPI commands are non-functioning as they come from Arduino, so don't exist in LUFA

* Convert SPI commands from arduino to LUFA

But I have no idea if this is actually correct or not

* Update keyboard readme

* Clean up ploopyco trackball

* Update readme

* Update mouse key stuff

* last minutue cleanup

* Add caveat about scroll wheel

* Fixup to code

* Additional fixup

* Add movement multiplier

* Rename folders

* mid changes

* temp

* Got it working!!!!!

* Additional cleanup of code

* Make unused pin calls more compact

* Rotation info

* Add debouncing checks

* Make everything replaceable

* Add info.json

* Include ISP flashing info

* Better handling for user customization

* Reconfigure CPI stuff

* fix issues with debug printing

* Fix tiny scroll issue

* Add and update scroll code from ploopy mouse

* Update licensing

* Add PloopyCo Mouse

* Cleanup and layout stuff

* Move common files to main folder for reuse

* Increase polling rate

* Update image for mouse

* Apply changes from code review

* Add VIA support
@fauxpark
Merge pull request qmk#10457 from 2Moons-JP/trifecta_keymap
45c2a05
@mechmerlin
Swapparoo of bottom row keys (qmk#10277)
c7599bf
@jmschneider
[Keyboard] Add SiCK-PAD handwired keyboard (qmk#10429)
2eeb30c 
* Add sick_pad

* Adjust setup for Proton C

* Add readme

* Add info.json

* Make requested changes

* Resolve PR issues
@mrsendyyk
Update mrsendyyk Community Layouts (qmk#10338)
d844f5a 
* Add layouts/community/numpad_5x4/mrsendyyk

* Update keymap.c

* Update readme.md

* Update readme.md

* Update readme.md

* Rename my community layouts

* Rename

* Rename

* Cleanup my code

* Update readme.md

* Cleanup

* Update keymap.c

* Delete unnecessary files
@riblee
Add Unicode modes for handwired/riblee_f401:riblee (qmk#10461)
284a526 
* Add unicode modes

* Update keyboards/handwired/riblee_f401/keymaps/riblee/config.h
@swiftrax
[Keyboard] Add astro65 handwired (qmk#10449)
9f36aa6 
* Add pandemic keyboard

* Fix default keymap

* Add via keymap

* Fix via keymap

* Fix keymaps and pandamic.h

* add info.json

* update info.json

* Apply suggestions from code review

* Update keyboards/handwired/swiftrax/pandamic/info.json

* make suggested changes

* Add astro65

* fix info.json

* Apply suggestions from code review

* add more layers for via

* Apply suggestions from code review

* halp

* add other layout

* fix astro65.h

* commit suggestions

* Update keyboards/handwired/swiftrax/astro65/info.json
@jesusvallejo
Merge pull request #9 from msvisser/anne_pro
c9c1f77 
update
@jesusvallejo
Merge pull request #11 from qmk/master
7b87410 
update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvisser msvisser msvisser requested changes

Assignees

@msvisser msvisser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.