Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: fix build error #4053

Merged
merged 1 commit into from
Sep 15, 2023
Merged

protobuf: fix build error #4053

merged 1 commit into from
Sep 15, 2023

Conversation

mmuetzel
Copy link
Collaborator

Protobuf doesn't build for staging with the following error:

  google/protobuf/struct.pb.cc: At global scope:
  google/protobuf/struct.pb.cc:47:110: error: 'constinit' variable 'google::protobuf::_Struct_default_instance_' does not have a constant initializer
     47 | PROTOBUF_ATTRIBUTE_NO_DESTROY PROTOBUF_CONSTINIT PROTOBUF_ATTRIBUTE_INIT_PRIORITY1 StructDefaultTypeInternal _Struct_default_instance_;
        |                                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
  google/protobuf/struct.pb.cc:47:110:   in 'constexpr' expansion of 'google::protobuf::StructDefaultTypeInternal()'
  google/protobuf/struct.pb.cc:41:9: error: 'constexpr google::protobuf::Struct::Struct(google::protobuf::internal::ConstantInitialized)' called in a constant expression
     41 |       : _instance(::_pbi::ConstantInitialized{}) {}
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  google/protobuf/struct.pb.cc:35:20: note: 'constexpr google::protobuf::Struct::Struct(google::protobuf::internal::ConstantInitialized)' declared here
     35 | PROTOBUF_CONSTEXPR Struct::Struct(
        |                    ^~~~~~
  make[2]: *** [Makefile:4514: google/protobuf/struct.pb.lo] Error 1

Use patch based on upstream to avoid that build error.

@lazka
Copy link
Member

lazka commented Sep 15, 2023

oh, thanks. I had already given up :)

@mmuetzel
Copy link
Collaborator Author

No worries. Feel free to close if this is no longer needed.

@lazka lazka merged commit 4c729e6 into msys2:master Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants