ncurses: disable term-driver again to fix regressions #4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It breaks colors with nano for some reason, see msys2#4945 Fixes msys2#4945
|
If you look at my patch, you will see that it's impossible for there to be any regressrion: https://mail.gnu.org/archive/html/bug-ncurses/2024-08/msg00009.html . The patch does nothing except allow the term-driver code to be enabled, which has no effect otherwise. Furthermore, I proved that the binary package that resulted from that PR was compromised here: |
|
If the term-driver actually works now, I'd rather fix whatever the problem in Nano is, and if |
|
I can reproduce it breaking nano colors. Ideas how to fix things welcome. I'm happy to test them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It breaks colors with nano for some reason, see
#4945
Fixes #4945