Use `Bytes` to avoid double indirection with `Arc<Vec<u8>>` #118

nazar-pc · 2024-10-12T01:05:56Z

Due to inner mutation Bytes had to be used instead of Arc<[u8]>, which achieves the same result as before, but without double indirection that was used before. Public API is unchanged.

BytesMut::from(Bytes) attempts to reuse allocation just like Arc::make_mut() did before.

Fixes #117

jxs

LGTM, thanks Nazar

Use Bytes to avoid double indirection with Arc<Vec<u8>>

1eeade6

jxs approved these changes Oct 14, 2024

View reviewed changes

jxs merged commit fe847fa into multiformats:master Oct 14, 2024
4 checks passed

nazar-pc deleted the use-bytes branch October 14, 2024 19:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `Bytes` to avoid double indirection with `Arc<Vec<u8>>` #118

Use `Bytes` to avoid double indirection with `Arc<Vec<u8>>` #118

nazar-pc commented Oct 12, 2024 •

edited

Loading

jxs left a comment

Use Bytes to avoid double indirection with Arc<Vec<u8>> #118

Use Bytes to avoid double indirection with Arc<Vec<u8>> #118

Conversation

nazar-pc commented Oct 12, 2024 • edited Loading

jxs left a comment

Choose a reason for hiding this comment

Use `Bytes` to avoid double indirection with `Arc<Vec<u8>>` #118

Use `Bytes` to avoid double indirection with `Arc<Vec<u8>>` #118

nazar-pc commented Oct 12, 2024 •

edited

Loading