Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove time argument to accept-process-output #78

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

Panadestein
Copy link
Contributor

@Panadestein Panadestein commented Jun 22, 2024

A mini PR. Setting the time argument to 0.1 throws an error if the command's execution takes longer than that in the coming buffer. This is the result of tdoe:

Debugger entered--Lisp error: (error "Selecting deleted buffer")
  comint-redirect-preoutput-filter("@\n")
  comint-redirect-filter(comint-output-filter #<process BQN> "@\n")
  apply(comint-redirect-filter comint-output-filter (#<process BQN> "@\n"))
  #f(advice comint-redirect-filter :around comint-output-filter)(#<process BQN> "@\n")

By using the default, the error disappears.

Setting the time argument causes the command execution to fail for long command. This is the result of `tdoe`:

```elisp
Debugger entered--Lisp error: (error "Selecting deleted buffer")
  comint-redirect-preoutput-filter("@\n")
  comint-redirect-filter(comint-output-filter #<process BQN> "@\n")
  apply(comint-redirect-filter comint-output-filter (#<process BQN> "@\n"))
  #f(advice comint-redirect-filter :around comint-output-filter)(#<process BQN> "@\n")
```

By removing it, the error disappears.
@AndersonTorres
Copy link
Member

The error message from melpazoid is a bit strange.

Nonetheless I will rebase.

@AndersonTorres AndersonTorres merged commit b2a524b into museoa:trunk Jun 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants