Add bqn-comint-use-overlay
#79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slotThe
commented
Sep 8, 2024
bqn-mode.el
Outdated
| (if bqn-comint-use-overlay | ||
| (eros--make-result-overlay response | ||
| :where end | ||
| :duration eros-eval-result-duration) |
There was a problem hiding this comment.
Adjusting the format might be desirable so that multiline arrays display nicely; suggestions welcome
There was a problem hiding this comment.
Rebased + I think I found a relatively acceptable solution; one-line results are displayed like this:
and as soon as we go multiline, we change to
Plus, when called with a universal argument, the result is inserted into the buffer:
Show inline results using overlays, instead of just the minibuffer.
When called with a prefix argument. This emulates the behaviour of a few modes for lisp dialects, like CIDER.
|
Merged at 668e3f5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A custom toggle to show inline results using overlays, instead of just the minibuffer. Preview:
This adds an additional dependency on eros but it's only loaded if the functionality is actually used.