Add bqn-comint-bring
#80
Conversation
Instead of one unique *BQN* buffer, create a new one for every buffer. This feels more intuitive than all sessions sharing the global instance, especially when using system functions that actually talk to the OS—which directory one is in matters.
Toggle between the comint buffer and its associated buffer. Bound to C-c C-z by default, as this seems to be quite common among other major modes.
| (let* ((pref (bqn--comint-prefix)) | ||
| (buf (or (buffer-file-name) (buffer-name)))) | ||
| (if (string-prefix-p pref buf) | ||
| buf | ||
| (concat pref buf bqn--comint-suffix)))) |
There was a problem hiding this comment.
One could also use some internal state to keep track of comint buffer–buffer associations, but I figured since this is the only state that's currently needed this would be a bit overkill
|
Hum... |
| @@ -266,6 +266,7 @@ BQN buffers (or recreate them)." | |||
| (when bqn-glyph-map-modifier | |||
| (set-keymap-parent bqn-mode-map | |||
| (make-composed-keymap prog-mode-map bqn--glyph-map))) | |||
| (keymap-set bqn-mode-map "C-c C-z" #'bqn-comint-bring) | |||
There was a problem hiding this comment.
I split the keymap modifications because I think it is a little bit controversial to bind keys "by default".
https://github.com/positron-solutions/user-keys?tab=readme-ov-file#please-package-authors
There was a problem hiding this comment.
I thought a little bit about this, but since keybindings of the form C-c C-«letter» are reserved for major modes I figured it was fine. I think that it helps with discoverability, personally, and unbinding a keybinding from a keymap is not all that difficult. Though I don't feel too strongly either way and am fine with dropping this part if you'd prefer
EDIT: I now see that the link you posted talks about this in some length in another place. As I said, no strong opinions from me
Looks fine to me, thanks! 👍 |
|
New melpazoid warnings from this PR seem to be the following: If we decide to keep the commit, one can also user the (now deprecated) |
Wouldn't |
Rebased, thanks! Solved at https://github.com/museoa/bqn-mode/releases/tag/2024-09-10 |
Lots of other major modes with REPL-like functionality have some way to toggle between it and the buffer it's associated to. This is something I missed from
bqn-mode, so here we are.Additionally, there is a breaking change lurking here, technically: the BQN comint process is now associated to a particular buffer, instead of being global. In my opinion, this is much more natural anyways, but YMMV. Of course, this can always be made into a backwards-compatible toggle.
Commit Summary
Create a unique BQN comint process per buffer
Instead of one unique
*BQN*buffer, create a new one for every buffer. This feels more intuitive than all sessions sharing the global instance, especially when using system functions that actually talk to the OS—which directory one is in matters.Add bqn-comint-bring
Toggle between the comint buffer and its associated buffer. Bound to
C-c C-zby default, as this seems to be quite common among other major modes.