Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/expand.c: avoid assignment of incompatibple pointers #1

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

trofi
Copy link

@trofi trofi commented Dec 1, 2023

Upcoming gcc-14 added and enabled as an error by default the check for assignment of incompatible pointers. There mcpp build fails as:

expand.c: In function 'replace':
expand.c:713:21: error: assignment to 'char *' from incompatible pointer type 'LOCATION *' {aka 'struct location *'} [-Wincompatible-pointer-types]
  713 |         m_inf->args = m_inf->loc_args = NULL;       /* Default args */
      |                     ^

The mismatch happens because args and loc_args have incompatible types:

char *          args;
LOCATION *      loc_args;

The change splits pointer assignments in two.

Upcoming `gcc-14` added and enabled as an error by default the check for
assignment of incompatible pointers. There `mcpp` build fails as:

    expand.c: In function 'replace':
    expand.c:713:21: error: assignment to 'char *' from incompatible pointer type 'LOCATION *' {aka 'struct location *'} [-Wincompatible-pointer-types]
      713 |         m_inf->args = m_inf->loc_args = NULL;       /* Default args */
          |                     ^

The mismatch happens because `args` and `loc_args` have incompatible
types:

    char *          args;
    LOCATION *      loc_args;

The change splits pointer assignments in two.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant