Switch to Distube's ytdl-core fork (resolves playback issue) #1042

MarcoCoreDuo · 2024-07-12T18:25:55Z

I don't think ytdl-core will receive any updates anymore and play-dl also has this playback issue. Distube's fork has some extra fixes and also updated decipher code (resolves the playback issue). It works as a drop-in replacement. The only downside is that it needs nodejs >= 18.

I updated the changelog

EugeneLeclerc · 2024-07-12T19:04:55Z

Well I just did the same, you were 30 minutes faster than me: #1044

While we are updating Node, I think we could go directly to Node 20? It is the current LTS and has been for quite a while already.

github-actions · 2024-07-12T19:57:53Z

📦 A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-1042 or codetheweb/muse:3c161b77dd2d8148e7821d470ae550626a24b196.

Images are available for x86_64 and ARM64.

Latest commit: 3c161b7

MarcoCoreDuo · 2024-07-12T20:10:12Z

Well I just did the same, you were 30 minutes faster than me: #1044

While we are updating Node, I think we could go directly to Node 20? It is the current LTS and has been for quite a while already.

I'm not really sure if we could use Node 20 without updating dependencies. I am glad that the current Dockerfile now works (Debian-Bookworm had a too-new libc-bin). But I can try building the Dockerfile with Node 20.

EugeneLeclerc · 2024-07-12T20:20:52Z

I'm not really sure if we could use Node 20 without updating dependencies. I am glad that the current Dockerfile now works (Debian-Bookworm had a too-new libc-bin). But I can try building the Dockerfile with Node 20.

Yeah getting things working in the priority I guess, Node 20 can wait 😄

MarcoCoreDuo · 2024-07-12T21:19:13Z

I'm not really sure if we could use Node 20 without updating dependencies. I am glad that the current Dockerfile now works (Debian-Bookworm had a too-new libc-bin). But I can try building the Dockerfile with Node 20.
Yeah getting things working in the priority I guess, Node 20 can wait 😄

I tried building the image with Node 20, and it does not work because there are no pre-built binaries for @discordjs/opus. So Node 20 would require Python and build tools in the image.

jamcdon · 2024-07-16T01:44:08Z

package.json

@@ -89,6 +89,7 @@
    "@discordjs/opus": "^0.8.0",
    "@discordjs/rest": "1.0.1",
    "@discordjs/voice": "0.11.0",
+    "@distube/ytdl-core": "^4.13.5",


Could fix current bug in bot

2KDrop · 2024-07-16T15:01:20Z

Tried running the PR and while it plays songs fine when the queue runs out the bot crashes immediately with the error "No songs in queue to forward to."

Error: No songs in queue to forward to.
at default.manualForward (/usr/app/src/services/player.ts:315:13)
at default.forward (/usr/app/src/services/player.ts:277:10)
at default.onAudioPlayerIdle (/usr/app/src/services/player.ts:586:18)
at AudioPlayer.emit (node:events:517:28)
at AudioPlayer.set state (/usr/app/node_modules/@discordjs/voice/src/audio/AudioPlayer.ts:356:9)
at AudioPlayer.stop (/usr/app/node_modules/@discordjs/voice/src/audio/AudioPlayer.ts:493:9)
at default.forward (/usr/app/src/services/player.ts:283:27)
at default_1.execute (/usr/app/src/commands/skip.ts:37:20)
at Client. (/usr/app/src/bot.ts:79:27)
at Client.emit (node:events:517:28)

Running on Linux Mint through Docker, unsure if that means anything for it

Stealthii · 2024-07-16T21:55:00Z

Using the suggested codetheweb/muse:pr-1042 image, I've seen the issue resolved, and not encountered any other warnings or issues during a few hours testing.

2KDrop · 2024-07-17T03:29:20Z

Did further testing, seems to happen only when skipping the last song in the queue or skipping to the last song in the queue, have tested 3 videos and gotten the same results from all of them.

Old Gods of Asgard's Herald of Darkness audio track - https://www.youtube.com/watch?v=TyC1NzSmFIg
Noah's Face to Face audio track - https://www.youtube.com/watch?v=oLcoljNKh3I
Fart with reverb sound effect - https://www.youtube.com/watch?v=9FLRHejWAo8

All play through fine but upon skipping to the last or the last video itself the bot crashes with the error below.

/usr/app/src/services/player.ts:315
throw new Error('No songs in queue to forward to.');
^

Error: No songs in queue to forward to.
at default.manualForward (/usr/app/src/services/player.ts:315:13)
at default.forward (/usr/app/src/services/player.ts:277:10)
at default.onAudioPlayerIdle (/usr/app/src/services/player.ts:586:18)
at AudioPlayer.emit (node:events:517:28)
at AudioPlayer.set state (/usr/app/node_modules/@discordjs/voice/src/audio/AudioPlayer.ts:356:9)
at AudioPlayer.stop (/usr/app/node_modules/@discordjs/voice/src/audio/AudioPlayer.ts:493:9)
at default.forward (/usr/app/src/services/player.ts:283:27)
at default_1.execute (/usr/app/src/commands/skip.ts:37:20)
at Client. (/usr/app/src/bot.ts:79:27)
at Client.emit (node:events:517:28)

Node.js v18.20.4

I've attached a screenshot to showcase an example of what to do to recreate the bug

MarcoCoreDuo · 2024-07-17T10:27:00Z

Did further testing, seems to happen only when skipping the last song in the queue or skipping to the last song in the queue, have tested 3 videos and gotten the same results from all of them.

Old Gods of Asgard's Herald of Darkness audio track - https://www.youtube.com/watch?v=TyC1NzSmFIg Noah's Face to Face audio track - https://www.youtube.com/watch?v=oLcoljNKh3I Fart with reverb sound effect - https://www.youtube.com/watch?v=9FLRHejWAo8

All play through fine but upon skipping to the last or the last video itself the bot crashes with the error below.

/usr/app/src/services/player.ts:315 throw new Error('No songs in queue to forward to.'); ^

Error: No songs in queue to forward to. at default.manualForward (/usr/app/src/services/player.ts:315:13) at default.forward (/usr/app/src/services/player.ts:277:10) at default.onAudioPlayerIdle (/usr/app/src/services/player.ts:586:18) at AudioPlayer.emit (node:events:517:28) at AudioPlayer.set state (/usr/app/node_modules/@discordjs/voice/src/audio/AudioPlayer.ts:356:9) at AudioPlayer.stop (/usr/app/node_modules/@discordjs/voice/src/audio/AudioPlayer.ts:493:9) at default.forward (/usr/app/src/services/player.ts:283:27) at default_1.execute (/usr/app/src/commands/skip.ts:37:20) at Client. (/usr/app/src/bot.ts:79:27) at Client.emit (node:events:517:28)

Node.js v18.20.4

I've attached a screenshot to showcase an example of what to do to recreate the bug

Thank you for reporting. This was an error from a different pr by me. This also resulted in the bot always skipping an additional song. Should now be fixed.

Stealthii · 2024-07-17T20:56:55Z

Using the suggested codetheweb/muse:pr-1042 image, I've seen the issue resolved, and not encountered any other warnings or issues during a few hours testing.

Spoke too soon, got these exceptions today:

tmp-muse-1  | Error: type lockupViewModel is not known
tmp-muse-1  |     at parseItem (/usr/app/node_modules/ytsr/lib/parseItem.js:83:13)
tmp-muse-1  |     at catchAndLogFunc (/usr/app/node_modules/ytsr/lib/parseItem.js:90:12)
tmp-muse-1  |     at module.exports (/usr/app/node_modules/ytsr/lib/parseItem.js:119:46)
tmp-muse-1  |     at /usr/app/node_modules/ytsr/lib/main.js:53:34
tmp-muse-1  |     at Array.map (<anonymous>)
tmp-muse-1  |     at module.exports (/usr/app/node_modules/ytsr/lib/main.js:53:25)
tmp-muse-1  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
tmp-muse-1  |     at KeyValueCacheProvider.wrap (/usr/app/src/services/key-value-cache.ts:53:20)
tmp-muse-1  |     at async run (file:///usr/app/node_modules/p-queue/dist/index.js:109:36)
tmp-muse-1  |
tmp-muse-1  | /********************************************************************************************************************************************************************************************************
tmp-muse-1  | failed at func parseItem: type lockupViewModel is not known
tmp-muse-1  | pls post the the files in /usr/app/node_modules/ytsr/dumps to https://github.com/TimeForANinja/node-ytsr/issues
tmp-muse-1  | os: linux-x64, node.js: v18.20.4, ytsr: 3.8.4

I've just pulled the updates from 3c161b7 and will test today.

MarcoCoreDuo · 2024-07-17T21:51:48Z

Using the suggested codetheweb/muse:pr-1042 image, I've seen the issue resolved, and not encountered any other warnings or issues during a few hours testing.

Spoke too soon, got these exceptions today:

tmp-muse-1  | Error: type lockupViewModel is not known
tmp-muse-1  |     at parseItem (/usr/app/node_modules/ytsr/lib/parseItem.js:83:13)
tmp-muse-1  |     at catchAndLogFunc (/usr/app/node_modules/ytsr/lib/parseItem.js:90:12)
tmp-muse-1  |     at module.exports (/usr/app/node_modules/ytsr/lib/parseItem.js:119:46)
tmp-muse-1  |     at /usr/app/node_modules/ytsr/lib/main.js:53:34
tmp-muse-1  |     at Array.map (<anonymous>)
tmp-muse-1  |     at module.exports (/usr/app/node_modules/ytsr/lib/main.js:53:25)
tmp-muse-1  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
tmp-muse-1  |     at KeyValueCacheProvider.wrap (/usr/app/src/services/key-value-cache.ts:53:20)
tmp-muse-1  |     at async run (file:///usr/app/node_modules/p-queue/dist/index.js:109:36)
tmp-muse-1  |
tmp-muse-1  | /********************************************************************************************************************************************************************************************************
tmp-muse-1  | failed at func parseItem: type lockupViewModel is not known
tmp-muse-1  | pls post the the files in /usr/app/node_modules/ytsr/dumps to https://github.com/TimeForANinja/node-ytsr/issues
tmp-muse-1  | os: linux-x64, node.js: v18.20.4, ytsr: 3.8.4

I've just pulled the updates from 3c161b7 and will test today.

I think this isn't an issue caused by this PR (see #1000). It's an error with ytsr (deprecated module for doing YT search requests). There is also an open PR for replacing it with Distube's fork #1024.

EugeneLeclerc · 2024-07-17T21:57:08Z

I think this isn't an issue caused by this PR (see #1000). It's an error with ytsr (deprecated module for doing YT search requests). There is also an open PR for replacing it with Distube's fork #1024.

Yeah this PR cannot and should not fix everything. The 403 errors are fixed, thats already a good enough reason to merge as-is.

codetheweb

sorry for the delay, thank you for the patch!

github-actions · 2024-07-18T04:53:14Z

🚀 Released in Release v2.9.0.

MarcoCoreDuo added 4 commits July 12, 2024 15:32

Switch to distube's ytdl-core fork

ead342c

Remove ytdl-core patch

8cdf1d6

Updated changelog

1a14b8b

bump required node version and use latest node 18 image in Dockerfile

fde5e02

EugeneLeclerc mentioned this pull request Jul 12, 2024

Change dependency from 'ytdl-core' to '@distube/ytdl-core' #1044

Closed

EugeneLeclerc mentioned this pull request Jul 12, 2024

Unable to play any songs #1037

Closed

3 tasks

change docker image to node:18-bullseye-slim

584bb17

MarcoCoreDuo force-pushed the distube-ytdl-core branch from 9468cd8 to 584bb17 Compare July 12, 2024 19:53

Update README.md

d320c27

jamcdon approved these changes Jul 16, 2024

View reviewed changes

fix skip error and update readme

3c161b7

codetheweb approved these changes Jul 18, 2024

View reviewed changes

codetheweb merged commit fcc8d88 into museofficial:master Jul 18, 2024
5 checks passed

codetheweb mentioned this pull request Jul 18, 2024

Switch from node-ytsr to Distube's fork #1024

Merged

MarcoCoreDuo deleted the distube-ytdl-core branch July 18, 2024 13:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to Distube's ytdl-core fork (resolves playback issue) #1042

Switch to Distube's ytdl-core fork (resolves playback issue) #1042

MarcoCoreDuo commented Jul 12, 2024

EugeneLeclerc commented Jul 12, 2024

github-actions bot commented Jul 12, 2024 •

edited

Loading

MarcoCoreDuo commented Jul 12, 2024

EugeneLeclerc commented Jul 12, 2024 •

edited

Loading

MarcoCoreDuo commented Jul 12, 2024

jamcdon Jul 16, 2024

2KDrop commented Jul 16, 2024

Stealthii commented Jul 16, 2024

2KDrop commented Jul 17, 2024

MarcoCoreDuo commented Jul 17, 2024 •

edited

Loading

Stealthii commented Jul 17, 2024

MarcoCoreDuo commented Jul 17, 2024

EugeneLeclerc commented Jul 17, 2024

codetheweb left a comment

github-actions bot commented Jul 18, 2024

Switch to Distube's ytdl-core fork (resolves playback issue) #1042

Switch to Distube's ytdl-core fork (resolves playback issue) #1042

Conversation

MarcoCoreDuo commented Jul 12, 2024

EugeneLeclerc commented Jul 12, 2024

github-actions bot commented Jul 12, 2024 • edited Loading

📦 A new release has been made for this pull request.

MarcoCoreDuo commented Jul 12, 2024

EugeneLeclerc commented Jul 12, 2024 • edited Loading

MarcoCoreDuo commented Jul 12, 2024

jamcdon Jul 16, 2024

Choose a reason for hiding this comment

2KDrop commented Jul 16, 2024

Stealthii commented Jul 16, 2024

2KDrop commented Jul 17, 2024

MarcoCoreDuo commented Jul 17, 2024 • edited Loading

Stealthii commented Jul 17, 2024

MarcoCoreDuo commented Jul 17, 2024

EugeneLeclerc commented Jul 17, 2024

codetheweb left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 18, 2024

github-actions bot commented Jul 12, 2024 •

edited

Loading

EugeneLeclerc commented Jul 12, 2024 •

edited

Loading

MarcoCoreDuo commented Jul 17, 2024 •

edited

Loading