Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add users endpoint #163

Closed
wants to merge 2 commits into from
Closed

feat: add users endpoint #163

wants to merge 2 commits into from

Conversation

remcohendriks
Copy link
Contributor

Adds GET endpoints for 1) all users with pagination 2) single/multiple user endpoint

Copy link
Contributor

@Cysword Cysword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests gaan wel fout

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (ae186f0) to head (a4c14e3).
Report is 1 commits behind head on main.

Files Patch % Lines
src/endpoints/private/users/User.types.ts 0.00% 36 Missing and 1 partial ⚠️
src/endpoints/private/users/GetUser.ts 94.11% 0 Missing and 1 partial ⚠️
src/endpoints/private/users/GetUsers.ts 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   92.93%   91.48%   -1.45%     
==========================================
  Files          96      100       +4     
  Lines        2249     2326      +77     
  Branches      125      128       +3     
==========================================
+ Hits         2090     2128      +38     
- Misses         34       70      +36     
- Partials      125      128       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage moet nog

public readonly path = 'users';
public readonly property = 'users';
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jouw editor lijkt iets geks te doen met newlines aan het eind

auto-merge was automatically disabled October 1, 2024 08:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

4 participants