Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix deprecation warning on arrayAccess::offsetGet #305

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

EdieLemoine
Copy link
Member

@EdieLemoine EdieLemoine commented Sep 11, 2024

INT-623

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (ac2ac72) to head (119caf5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/Base/Concern/OffsetGetPhp8.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #305      +/-   ##
============================================
- Coverage     96.23%   96.19%   -0.04%     
- Complexity     1664     1665       +1     
============================================
  Files           309      311       +2     
  Lines          5523     5525       +2     
============================================
  Hits           5315     5315              
- Misses          208      210       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the fix/deprecation-warning-offset-get branch from 12a9fa2 to bff22f4 Compare September 13, 2024 07:46
@EdieLemoine EdieLemoine force-pushed the fix/deprecation-warning-offset-get branch from 43fc586 to 119caf5 Compare September 13, 2024 14:19
@myparcel-bot myparcel-bot bot added the approved (Auto) label Sep 20, 2024
@EdieLemoine EdieLemoine merged commit 82eb15b into main Sep 25, 2024
11 of 13 checks passed
@EdieLemoine EdieLemoine deleted the fix/deprecation-warning-offset-get branch September 25, 2024 11:10
myparcel-bot bot added a commit that referenced this pull request Sep 25, 2024
## [2.43.3](v2.43.2...v2.43.3) (2024-09-25)

### 🐛 Bug Fixes

* fix deprecation warning on arrayAccess::offsetGet ([#305](#305)) ([82eb15b](82eb15b))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Sep 25, 2024

🎉 This PR is included in version 2.43.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants