Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orders): export correct recipient name #277

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

EdieLemoine
Copy link
Member

@EdieLemoine EdieLemoine commented Oct 9, 2024

Resolves #266

@EdieLemoine EdieLemoine requested a review from a team as a code owner October 9, 2024 11:54
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.00%. Comparing base (1fecb6d) to head (f1e08d2).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #277      +/-   ##
============================================
+ Coverage     46.82%   47.00%   +0.18%     
  Complexity      561      561              
============================================
  Files           148      148              
  Lines          3607     3610       +3     
  Branches         55       55              
============================================
+ Hits           1689     1697       +8     
+ Misses         1863     1858       -5     
  Partials         55       55              
Flag Coverage Δ
backend 76.54% <100.00%> (+0.25%) ⬆️
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Oct 9, 2024

PDK upgrade summary

The following packages were upgraded:

Package Old version New version
myparcelnl/pdk 2.42.0 2.43.4

@myparcel-bot myparcel-bot bot force-pushed the fix/orders-recipient-address branch 8 times, most recently from fee2e9f to 36ea5de Compare October 9, 2024 15:27
FreekVR

This comment was marked as duplicate.

@FreekVR FreekVR self-requested a review October 11, 2024 13:32
Copy link

@FreekVR FreekVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functioneel geen aanmerkingen, zie alleen 2x kleine codestyle feedback van Codacy die wel netjes zijn om nog op te lossen.

Ook nog een tweetal failures in de testsuite - mismatch tussen integer en boolean return value / expectations

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Oct 11, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/orders-recipient-address branch 3 times, most recently from 9f45a4c to 265695b Compare October 16, 2024 10:35
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Oct 16, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit f7d36ca
Logs https://github.com/myparcelnl/prestashop/actions/runs/11364467160
Download https://github.com/myparcelnl/prestashop/suites/29688812064/artifacts/2062930318

@EdieLemoine EdieLemoine changed the base branch from beta to main October 16, 2024 11:35
@myparcel-bot myparcel-bot bot force-pushed the fix/orders-recipient-address branch from f7d36ca to f1e08d2 Compare October 16, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Module uses customer information from account rather than from address
2 participants