Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(admin): only save product settings once per request #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EdieLemoine
Copy link
Member

No description provided.

@EdieLemoine EdieLemoine requested a review from a team as a code owner October 10, 2024 15:07
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.82%. Comparing base (1fecb6d) to head (a0fdc37).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #279   +/-   ##
=========================================
  Coverage     46.82%   46.82%           
  Complexity      561      561           
=========================================
  Files           148      148           
  Lines          3607     3607           
  Branches         55       55           
=========================================
  Hits           1689     1689           
  Misses         1863     1863           
  Partials         55       55           
Flag Coverage Δ
backend 76.28% <ø> (ø)
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot added the approved (Auto) label Oct 11, 2024
@myparcel-bot myparcel-bot bot force-pushed the perf/saving-product-settings branch from d1338d4 to edacec9 Compare October 11, 2024 12:45
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Oct 11, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit 6ebe2ff
Logs https://github.com/myparcelnl/prestashop/actions/runs/11363917463
Download https://github.com/myparcelnl/prestashop/suites/29687326746/artifacts/2062775940

@myparcel-bot myparcel-bot bot force-pushed the perf/saving-product-settings branch 3 times, most recently from 7255150 to 6ebe2ff Compare October 16, 2024 10:35
@EdieLemoine EdieLemoine changed the base branch from beta to main October 16, 2024 11:33
@myparcel-bot myparcel-bot bot force-pushed the perf/saving-product-settings branch from 6ebe2ff to a0fdc37 Compare October 16, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants