Adds option to disable N2N (#1439) #1475
Conversation
| @@ -553,6 +554,7 @@ bool transportRouteMessage(MyMessage &message) | |||
| } | |||
| TRANSPORT_DEBUG(PSTR("!TSF:RTE:N2N FAIL\n")); | |||
| } | |||
| #endif | |||
There was a problem hiding this comment.
How about adding an else clause here, with something like
TRANSPORT_DEBUG(PSTR("!TSF:RTE:N2N DIS\n")); so people who enable this feature and forget about it (or don’t fully realize what it does) can get some information on why their N2N messages disappear?
There was a problem hiding this comment.
Okay, I will try it out and check how it works.
| @@ -1111,6 +1111,12 @@ | |||
| #define MY_TRANSPORT_DISCOVERY_INTERVAL_MS (20*60*1000ul) | |||
| #endif | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Could you add a small note on when this feature can/should be used? Maybe some sort of use case description?
There was a problem hiding this comment.
Hi @mfalkvidd, my use case is a node that is located in a dead zone and can only be reached via a repeater.
When the node sends telegrams to other nodes or the gateway, I always get the error message !TSF:RTE:N2N FAIL in the log. This is a waste of node battery energy and in addition it pollutes the airwaves with traffic that interferes with the communication of other nodes.
There was a problem hiding this comment.
Do you know what causes the node to try to sent to other nodes?
There was a problem hiding this comment.
Hi @mfalkvidd, I am intentionally sending the message to another actuator node which unfortunately is not directly reachable via N2N.
|
Hi @mfalkvidd, I have implemented your suggested change and it works for me so far. I have omitted the '!' because it is not an error, but a setting. Are there any news regarding the CLA? |
|
Hi @mfalkvidd, I have now also extended the log parser for the new N2N disabled message. |
lelouch94
force-pushed
the
mwa_dev_Issue_1439
branch
from
c412a09
to
b09be9c
Compare
to disable the node to node transport feature
to describe the use case.
lelouch94
force-pushed
the
mwa_dev_Issue_1439
branch
from
b09be9c
to
68c54b7
Compare
This pull request adds the configuration option MY_TRANSPORT_N2N_FEATURE_DISABLED,
to disable the node to node transport feature.
see: #1439