Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed comile error for ESP8266 on newest toolchain #1560

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Fixed comile error for ESP8266 on newest toolchain #1560

wants to merge 3 commits into from

Conversation

eiten
Copy link
Contributor

@eiten eiten commented Feb 13, 2024

Toolchain has template functions max() and min() which are conflicting with the preprocessor defines.

@eiten
Copy link
Contributor Author

eiten commented Feb 14, 2024

I can't understand this....
Toll Gate failed, but in the details page, all the check marks are green...
Toll gate (ESP32 - Tests) failed with 27 warnings/errors, where:

  • 19 are from MySigningAtsha204.cpp where I did not change anything
  • 8 are from stl_algo.h and stl_algobase.h which belong to the framework...
    Any ideas what I did wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eiten