Ascii encoding gr #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rake was failing because PKG_NAME was not defined.
Looking at the MS reference [1], 001E or 001F should be PT_STRING8. Mapi::Types::DATA seems to ignore this. It sets 001f as PT_UNICODE, and this sort of maps to the original filter converting to UTF8. I say sort of, because I'm not sure how how Mapi::Types::DATA and Mapi::Msg::PropertySTore::ENCODINGS interact. This change at least makes both the existing and new spec pass ¯\_(ツ)_/¯ [1] https://msdn.microsoft.com/en-us/library/bb147591.aspx
garethrees
force-pushed
the
ascii-encoding-gr
branch
from
28cf730
to
43c8797
Compare
Alternative spec-passing version of the previous commit.
Another alternative spec-passing change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.