Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a cache volume for controller #499

Merged
merged 1 commit into from
May 5, 2022
Merged

add a cache volume for controller #499

merged 1 commit into from
May 5, 2022

Conversation

cortopy
Copy link
Contributor

@cortopy cortopy commented May 4, 2022

Current nack chart allows to set securityContext but this doesn't work.

As per nats-io/nack#48, the nack js controller will create a tmp directory in "/" which is not allowed if the container is not running as root

This PR adds a volume, so that the following works

securityContext:
  fsGroup: 1000
  runAsUser: 1000
  runAsNonRoot: true

@wallyqs wallyqs requested a review from variadico May 4, 2022 22:01
variadico
variadico approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@variadico variadico left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I was able to deploy this on a local cluster. No more CrashloopBackOff!
Thanks!

@variadico variadico merged commit 9410802 into nats-io:main May 5, 2022
@gkoutsoumpakis-form3 gkoutsoumpakis-form3 mentioned this pull request May 16, 2022
Merged
caleblloyd pushed a commit that referenced this pull request May 16, 2022
@gkoutsoumpakis-form3
Fix nack deployment when tls is used (#505)
c2d7885 
#499 introduced a duplicated <volumes>
tag that broke deployments where tls is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@variadico variadico variadico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cortopy @variadico