Allow location_type to use name for lookup #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently location_types that use the name to reference the related object will always report as "changed" since it compares the name with the ID of the existing location_type. Updated to convert name to ID.
|
|
Can you please change all |
should we test both? |
Sure, if you want to leave half as key that works too. |
jmcgill298
force-pushed
the
jmcgill/location_type-lookup
branch
from
0dfc8c7
to
ec33657
Compare
joewesch
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently location_types that use the name to reference the related object will always report as "changed" since it compares the name with the ID of the existing location_type. Updated to convert name to ID.