create controller_managed_device_groups #432
Conversation
pugnacity
requested review from
jvanderaa,
jmcgill298 and
joewesch
as code owners
| @@ -0,0 +1,36 @@ | |||
| --- | |||
There was a problem hiding this comment.
You will need to add your test file to the main.yml file for it to be picked up and run with the rest of the integration tests.
| that: | ||
| - test_two['changed'] | ||
| - test_two['controller_managed_device_group']['name'] == "Test Controller Group One" | ||
|
|
There was a problem hiding this comment.
For the integration tests, we try and stick to a pattern like this:
- Create with minimal required fields
- Try and create again to verify idempotency
- Create a second object with all fields
- Try and create again to verify idempotency
- Update one of the previous objects
- Try and update again to verify idempotency
- Delete one of the previous objects
- Try and delete again to verify idempotency
Please refactor your tests to follow this pattern.
| parent_location: "{{ lookup('networktocode.nautobot.lookup', 'locations', api_endpoint=nautobot_url, token=nautobot_token, api_filter='name=\"Parent Test Location\"') }}" | ||
|
|
||
| - name: "CONTROLLER 1: Necessary info creation" | ||
| networktocode.nautobot.controller: |
There was a problem hiding this comment.
To narrow the scope of the tests in this file, please move all creation of prerequisite items to the nautobot-populate.py file. You will find many examples in there to mimic.
| @@ -290,6 +296,7 @@ def main(): | |||
| vc_priority=dict(required=False, type="int"), | |||
| comments=dict(required=False, type="str"), | |||
| local_config_context_data=dict(required=False, type="dict"), | |||
| controller_managed_device_group=dict(required=False, type="raw"), | |||
There was a problem hiding this comment.
Can you please add this to one of the existing integration tests for device? You can follow this pattern to omit the field for the unsupported versions:
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
| {"name": "controller_one", "location": "Child Test Location", "status": {"name": "Active"}}, | ||
| {"name": "controller_two", "location": "Child Test Location", "status": {"name": "Active"}}, |
There was a problem hiding this comment.
@joewesch please give me a hint why this is not working.
There was a problem hiding this comment.
Your problem is here:
created_controller = make_nautobot_calls(nb.extras.controller, controller)Controllers aren't in the extras app, but rather the dcim app. Plus, the endpoint is plural (controllers):
created_controller = make_nautobot_calls(nb.dcim.controllers, controller)
| - name: "CONTROLLER 2: ASSERT - Create duplicate" | ||
| assert: | ||
| that: | ||
| - not test_two['changed'] | ||
| - test_two['controller_managed_device_group']['name'] == "Test Controller Group One" | ||
| - test_two['msg'] == "Test Controller Group One already exists" |
There was a problem hiding this comment.
This fails because of
"diff": {
"after": {
"controller": "controller_one"
},
"before": {
"controller": "ebe13ee7-b713-4d1b-b839-2ae0159996da"
}
}
Did I something wrong, or why is the change now with the ID?
There was a problem hiding this comment.
If the GET call returns the ID of the controller instead of the name you probably need to add controller to the CONVERT_TO_ID dictionary so the name gets converted for proper comparison.
This should fix #423